Avoid failures on cleaning #1749
Conversation
While working on integrating dnsmasq role in the reproducer, a random issue, related to the facts, might happen. It seems to be caused by the way ansible manages the handler - the `ansible_facts.packages` isn't available anymore, and the condition triggering the libvirt cleanup fails. While it was already done. This condition arrises when dnsmasq role is in the game, and the handler kicks at the end of the playbook. In the same fashion, the handler might be triggered when the service is already removed, leading to another crash of the cleanup playbook. The added conditions ensure the handler will succeed even if the service is already removed, but would still fail if there's a real issue with the service configuration.
|
Skipping CI for Draft Pull Request. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/7813c903c3a84928b5e36b26c7d5ef51 ❌ openstack-k8s-operators-content-provider FAILURE in 16m 46s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
While working on integrating dnsmasq role in the reproducer, a random
issue, related to the facts, might happen.
It seems to be caused by the way ansible manages the handler - the
ansible_facts.packagesisn't available anymore, and the conditiontriggering the libvirt cleanup fails. While it was already done.
This condition arrises when dnsmasq role is in the game, and the handler
kicks at the end of the playbook.
In the same fashion, the handler might be triggered when the service is
already removed, leading to another crash of the cleanup playbook. The
added conditions ensure the handler will succeed even if the service is
already removed, but would still fail if there's a real issue with the
service configuration.
As a pull request owner and reviewers, I checked that: