Shift on Stack DT #1744
Shift on Stack DT #1744
Conversation
|
Hi @mandre. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a2c59b6902a2455eb89254a6f52231c6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 22s |
Copied missing values from `va-hci.yaml`.
Renamed from `shift-on-stack-overrides.yml` to `dt-osasinfra.yml` to highlight that it deploys the osasinfra DT.
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ba32dedbe0a242f4a24b30c1e1d8af49 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 48s |
|
The dependent PR merged. @cjeanner could you review when you get a chance? |
|
/ok-to-test |
|
recheck |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@rlobillo: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abays you recently reviewed the osasinfra DT patch (openstack-k8s-operators/architecture#244), this is the needed cifm patch to enable it. Would you be able to take a look? |
@fultonj as well 😉 |
| ## devscript support for OCP deploy | ||
| cifmw_devscripts_config_overrides: | ||
| fips_mode: "{{ cifmw_fips_enabled | default(false) | bool }}" |
There was a problem hiding this comment.
I know certain things were moved out of cifmw_devscripts_config_overrides during #1777. Is fips_mode still valid here?
There was a problem hiding this comment.
Not sure if it's needed, or has any effect. I copied from the va-hci.yml reproducer.
There was a problem hiding this comment.
@cjeanner Do you know if fips_mode is still a valid option in cifmw_devscripts_config_overrides?
|
Tested on zuul on https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/tripleo-ci-internal/build/2c5369b3e12348998b62c8661ba85be6 The job failed, but it was due to shiftstack OCP cluster installation timing out because of lack of resources in the baremetal. The OSP18 installation with osasinfra DT was successful. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 11ffa84
into
openstack-k8s-operators:main
Depends on openstack-k8s-operators/architecture#244
Renamed the Shift on Stack overrides file from
shift-on-stack-overrides.ymltodt-osasinfra.ymlto highlight that it now deploys the osasinfra DT.As a pull request owner and reviewers, I checked that: