[dnsmasq] Refactor the role to be consumed by the ci_network role

[rebtoor]

Since the ci_network role has already its own task(s) to manage dns configuration, this PR will try to fill the gap in terms of functionality between both roles, so in the future dnsmasq role can be consumed by ci_network role with low effort.

As a pull request owner and reviewers, I checked that:

• Appropriate testing is done and actually running
• Appropriate documentation exists and/or is up-to-date:
  • README in the role
  • Content of the docs/source is reflecting the changes

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c9bcd21e46594800a416e07eebd53a72

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 38s
❌ cifmw-pod-pre-commit FAILURE in 7m 36s
✔️ cifmw-molecule-dnsmasq SUCCESS in 5m 10s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/80232633d22c4958ae023852de71d557

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 04s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 15s
❌ cifmw-molecule-dnsmasq FAILURE in 4m 00s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/90b8f1480d46445c9ec58ceebfde5188

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 49s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 15s
❌ cifmw-molecule-dnsmasq FAILURE in 5m 02s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d3ef94166bac404d96eaf45972ab25f0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 34s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 49s
❌ cifmw-molecule-dnsmasq FAILURE in 3m 57s

[cjeanner]

@hjensas care to have a look? The goal:

• modify dnsmasq role so that it can be used within ci_network role
• ensure it exposes the needed entry-points to nudge content "at will" while avoiding to rely on plain ansible.builtin.copy calls

[cjeanner]

so this means we're expected to know everything before we start to deploy dnsmasq? It may get slightly ugly pretty fast with the way we'll call things:

• deploy dnsmasq basics
• create libvirt networks (and add configuration snippets to dnsmasq for the DHCP)
• get to devscripts parts, where we have to inject yet other snippets, some related to DNS, listeners and so on

We therefore want to set target file names to ensure we can add content "on the fly".

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5ce47856c9a54728b7d73d8fdba2fcff

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 51s
❌ cifmw-molecule-dnsmasq FAILURE in 6m 04s

[rebtoor]

/label tide/merge-method-squash

[openshift-ci]

@rebtoor: The label(s) tide/merge-method-squash cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cjeanner]

/approve

I could run the fixed IP part with 32721e9 as last commit of this PR - and it's working fine apparently, at least for #1767 PR.

I propose to go with that version, and do the needed follow-ups with the needed changes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rebtoor]

/approve

I could run the fixed IP part with 32721e9 as last commit of this PR - and it's working fine apparently, at least for #1767 PR.

I propose to go with that version, and do the needed follow-ups with the needed changes.

@hjensas what do you think?

[hjensas]

/lgtm

I think we can merge this, and iterate on it.

IMO we should move listening address and interface to the "manage_network" tasks - i.e we start with installing a basic service that do nothing - then as we add networks/hosts/dns records with manage_network,manage_host,manage_address etc we add the interface and listen address, DNS records wildcards etc via those "api" task's.