Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[networking_mapper] Allow to speed up run #1726

Merged
merged 1 commit into from
May 29, 2024
Merged

[networking_mapper] Allow to speed up run #1726

merged 1 commit into from
May 29, 2024

Conversation

cjeanner
Copy link
Contributor

Introduces a new parameter to the role, to not gather networking facts
under certain circumstances.

This is for advanced usage only, and shouldn't be changed in most of the
cases.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role

@cjeanner cjeanner added the ipv6 label May 17, 2024
@openshift-ci openshift-ci bot requested review from dpinhas and rachael-george May 17, 2024 08:45
@github-actions github-actions bot marked this pull request as draft May 17, 2024 08:45
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4f3a28aecdc6441b824ddd8f27f9e02e

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 52s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 04s
❌ cifmw-pod-pre-commit FAILURE in 7m 05s
✔️ cifmw-molecule-networking_mapper SUCCESS in 5m 21s

@pablintino pablintino force-pushed the networking_mapper/speedup branch from d233925 to 8713b82 Compare May 20, 2024 14:46
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e6430136ac9641359fd5af9105a6c32c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 06s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 17s
❌ cifmw-pod-pre-commit FAILURE in 8m 21s
✔️ cifmw-molecule-networking_mapper SUCCESS in 6m 33s

@cjeanner cjeanner force-pushed the networking_mapper/speedup branch from 8713b82 to e28b49e Compare May 22, 2024 12:02
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d519bc2edead485ba67bf5de3bad7794

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 35s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 10s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 8m 15s
❌ cifmw-pod-pre-commit FAILURE in 8m 08s
❌ cifmw-molecule-networking_mapper FAILURE in 5m 34s

@cjeanner cjeanner force-pushed the networking_mapper/speedup branch 2 times, most recently from bdb69c8 to 0c50348 Compare May 22, 2024 15:17
@cjeanner
Copy link
Contributor Author

recheck

@cjeanner cjeanner marked this pull request as ready for review May 22, 2024 15:41
@openshift-ci openshift-ci bot requested review from afazekas and dsariel May 22, 2024 15:41
@cjeanner
Copy link
Contributor Author

/hold

we'll get the best-effort (#1692) in before

@cjeanner
[networking_mapper] Allow to speed up run
364a41b 
Introduces a new parameter to the role, to *not* gather networking facts
under certain circumstances.

This is for advanced usage only, and shouldn't be changed in most of the
cases.
@cjeanner cjeanner force-pushed the networking_mapper/speedup branch from 0c50348 to 364a41b Compare May 29, 2024 10:15
@cjeanner
Copy link
Contributor Author

/hold cancel

@pablintino
Copy link
Collaborator

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlandy
Copy link
Collaborator

rlandy commented May 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0a9547f into main May 29, 2024
6 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the networking_mapper/speedup branch May 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinhas dpinhas Awaiting requested review from dpinhas

@rachael-george rachael-george Awaiting requested review from rachael-george

@afazekas afazekas Awaiting requested review from afazekas

@dsariel dsariel Awaiting requested review from dsariel

Assignees

@rlandy rlandy

Labels
approved ipv6 lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjeanner @pablintino @rlandy