Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-operator] Expose nodeSelector and tolerations parameters #1716

Merged
merged 1 commit into from
May 16, 2024
Merged

[test-operator] Expose nodeSelector and tolerations parameters #1716

merged 1 commit into from
May 16, 2024
+10 −0

Conversation

lpiwowar
Copy link
Contributor

@lpiwowar lpiwowar commented May 16, 2024 •
edited
Loading

This patch exposes nodeSelector and tolerations parameters in the test-operator role. These two parameters were introduced to test-operator in the linked PR [1].

[1] openstack-k8s-operators/test-operator#95

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@openshift-ci openshift-ci bot requested review from arxcruz and dpinhas May 16, 2024 09:10
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft May 16, 2024 09:10
@lpiwowar lpiwowar force-pushed the feature/expose-tolerations branch from a48e92d to 41a8f05 Compare May 16, 2024 09:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/463ae88293b547838cda3aa86f5406fa

❌ openstack-k8s-operators-content-provider FAILURE in 6m 32s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 33s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 05s

@lpiwowar
[test-operator] Expose nodeSelector and tolerations parameters
71fba62 
This patch exposes nodeSelector and tolerations parameters in the
test-operator role. These two parameters were introduced to
test-operator in the linked PR [1]

[1] openstack-k8s-operators/test-operator#95
@lpiwowar lpiwowar force-pushed the feature/expose-tolerations branch from 41a8f05 to 71fba62 Compare May 16, 2024 09:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4c5c1679e6044a08ae54631b4b302bad

❌ openstack-k8s-operators-content-provider FAILURE in 6m 43s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 55s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 52s
✔️ cifmw-molecule-test_operator SUCCESS in 4m 57s

@lpiwowar
Copy link
Contributor Author

recheck

@lpiwowar lpiwowar marked this pull request as ready for review May 16, 2024 11:54
@openshift-ci openshift-ci bot requested review from dasm and pojadhav May 16, 2024 11:54
@openshift-ci openshift-ci bot added the lgtm label May 16, 2024
kopecmartin
kopecmartin approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit efda855 into openstack-k8s-operators:main May 16, 2024
8 of 12 checks passed
@lpiwowar lpiwowar deleted the feature/expose-tolerations branch May 16, 2024 14:39
eduolivares added a commit to eduolivares/ci-framework that referenced this pull request May 16, 2024
@eduolivares
Add tolerations and nodeSelector to test-operator-controller-manager
238e327 
In previous PR [1], tolerations and nodeSelector parameters were added
to the test_operator role in order to configure tempest and tobiko pods.
This new PR adds the option to apply those parameters to the
test-operator-controller-manager pod as well.

[1] openstack-k8s-operators#1716
eduolivares added a commit to eduolivares/ci-framework that referenced this pull request May 16, 2024
@eduolivares
Add tolerations and nodeSelector to test-operator-controller-manager
f477beb 
In previous PR [1], tolerations and nodeSelector parameters were added
to the test_operator role in order to configure tempest and tobiko pods.
This new PR adds the option to apply those parameters to the
test-operator-controller-manager pod as well.

[1] openstack-k8s-operators#1716
eduolivares added a commit to eduolivares/ci-framework that referenced this pull request May 16, 2024
@eduolivares
Add tolerations and nodeSelector to test-operator-controller-manager
9906a13 
In previous PR [1], tolerations and nodeSelector parameters were added
to the test_operator role in order to configure tempest and tobiko pods.
This new PR adds the option to apply those parameters to the
test-operator-controller-manager pod as well.

[1] openstack-k8s-operators#1716
@eduolivares eduolivares mentioned this pull request May 16, 2024
Merged
3 tasks
eduolivares added a commit to eduolivares/ci-framework that referenced this pull request May 16, 2024
@eduolivares
Add tolerations and nodeSelector to test-operator-controller-manager
b03b40d 
In previous PR [1], tolerations and nodeSelector parameters were added
to the test_operator role in order to configure tempest and tobiko pods.
This new PR adds the option to apply those parameters to the
test-operator-controller-manager and test-operator-logs pod as well.

[1] openstack-k8s-operators#1716
openshift-merge-bot bot pushed a commit that referenced this pull request May 17, 2024
@eduolivares @openshift-merge-bot
Add tolerations and nodeSelector to test-operator-controller-manager
9332a5c 
In previous PR [1], tolerations and nodeSelector parameters were added
to the test_operator role in order to configure tempest and tobiko pods.
This new PR adds the option to apply those parameters to the
test-operator-controller-manager and test-operator-logs pod as well.

[1] #1716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopecmartin kopecmartin kopecmartin approved these changes

@eduolivares eduolivares eduolivares approved these changes

@arxcruz arxcruz Awaiting requested review from arxcruz

@dpinhas dpinhas Awaiting requested review from dpinhas

@dasm dasm Awaiting requested review from dasm

@pojadhav pojadhav Awaiting requested review from pojadhav

Assignees

@kopecmartin kopecmartin

@eduolivares eduolivares

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpiwowar @kopecmartin @eduolivares