Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable DNS listener in dnsmasq #1711

Merged
merged 1 commit into from
May 16, 2024

Conversation

cjeanner
Copy link
Contributor

It might happen we want DNS on specific address, usually one associated
to a specific DHCP network.

Using the new parameter, we allow to pass a list of listeners, per
network. Dnsmasq will then listen and answer to DNS queries on those
addresses.

Note that you want to pass dhcp-options to ensure the DNS resolver is
properly passed, for instance:

options:
  - "option:dns-server,192.168.0.1"

in the network definition.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role

@openshift-ci openshift-ci bot requested review from cescgina and katarimanojk May 16, 2024 03:47
@github-actions github-actions bot marked this pull request as draft May 16, 2024 03:47
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/56360fbeebb240beb3b0c5e1d52238fb

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 33s
cifmw-molecule-dnsmasq FAILURE in 6m 23s

It might happen we want DNS on specific address, usually one associated
to a specific DHCP network.

Using the new parameter, we allow to pass a list of listeners, per
network. Dnsmasq will then listen and answer to DNS queries on those
addresses.

Note that you want to pass dhcp-options to ensure the DNS resolver is
properly passed, for instance:

```YAML
options:
  - "option:dns-server,192.168.0.1"
```
in the network definition.
@cjeanner cjeanner force-pushed the dnsmasq/enable-dns-resolver branch from 7e792f8 to fac36f6 Compare May 16, 2024 04:10
@cjeanner cjeanner marked this pull request as ready for review May 16, 2024 04:20
@openshift-ci openshift-ci bot requested review from arxcruz and dsariel May 16, 2024 04:20
@cjeanner cjeanner requested a review from hjensas May 16, 2024 04:20
Copy link
Contributor

@hjensas hjensas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f159f57 into main May 16, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the dnsmasq/enable-dns-resolver branch May 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants