-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to enable DNS listener in dnsmasq #1711
Conversation
Thanks for the PR! ❤️ |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/56360fbeebb240beb3b0c5e1d52238fb ✔️ noop SUCCESS in 0s |
It might happen we want DNS on specific address, usually one associated to a specific DHCP network. Using the new parameter, we allow to pass a list of listeners, per network. Dnsmasq will then listen and answer to DNS queries on those addresses. Note that you want to pass dhcp-options to ensure the DNS resolver is properly passed, for instance: ```YAML options: - "option:dns-server,192.168.0.1" ``` in the network definition.
7e792f8
to
fac36f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It might happen we want DNS on specific address, usually one associated
to a specific DHCP network.
Using the new parameter, we allow to pass a list of listeners, per
network. Dnsmasq will then listen and answer to DNS queries on those
addresses.
Note that you want to pass dhcp-options to ensure the DNS resolver is
properly passed, for instance:
in the network definition.
As a pull request owner and reviewers, I checked that: