Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auto-draft workflow to skip on nit: PRs #1710

Merged

Conversation

lewisdenny
Copy link
Collaborator

@lewisdenny lewisdenny commented May 16, 2024

Some tiny patches would be best skipping the auto-draft workflow as you are ready for them to be reviewed right away if CI passes. Adding nit: to the start start of your PR title will skip the auto-draft workflow.

Example: nit: Add full stop to docs

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • Content of the docs/source is reflecting the changes

Some tiny patches would be best skipping the auto-draft workflow as you are ready for them to be reviewed right away if CI passes. Adding nit: to the start start of your PR title will skip the auto-draft workflow.

Example: `nit: Add full stop to docs`
@openshift-ci openshift-ci bot requested review from marios and rachael-george May 16, 2024 01:04
@github-actions github-actions bot marked this pull request as draft May 16, 2024 01:04
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@lewisdenny lewisdenny requested review from cjeanner and removed request for marios and rachael-george May 16, 2024 01:04
@lewisdenny lewisdenny marked this pull request as ready for review May 16, 2024 01:05
@openshift-ci openshift-ci bot requested review from cescgina and frenzyfriday May 16, 2024 01:05
@cjeanner
Copy link
Contributor

/approve
/lgtm

Lovely approach, thank you @lewisdenny !

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b755e47 into openstack-k8s-operators:main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants