Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop for jump #1705

Merged

Conversation

kopecmartin
Copy link
Contributor

@kopecmartin kopecmartin commented May 15, 2024

item.path does not need the map(attribute='path'), that's a relict from #1675 PR.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

item.path does not need the map(attribute='path'), that's
a relict from openstack-k8s-operators#1675 PR.
@openshift-ci openshift-ci bot requested review from afazekas and lewisdenny May 15, 2024 10:15
@github-actions github-actions bot marked this pull request as draft May 15, 2024 10:15
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@kopecmartin kopecmartin marked this pull request as ready for review May 16, 2024 12:57
@openshift-ci openshift-ci bot requested review from bshewale and katarimanojk May 16, 2024 12:57
@kopecmartin
Copy link
Contributor Author

we've verified it works in the ci-framework-testproject repo , check PR 224 - the latest build failed but it did for a different reason (tldr, dfg name is case sensitive in jump) - we can see there though that the polarion call/task got rendered ok:
jump.py --testrun-id=create-new-test-run --xml-file=/home/zuul/ci-framework-data/tests/test_operator/tempest-tests/tempest_results.xml --update_testcases=true

@viroel
Copy link
Contributor

viroel commented May 16, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit df57b77 into openstack-k8s-operators:main May 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants