Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we have kubectl and kustomize on controller-0 #1699

Merged
merged 1 commit into from
May 15, 2024

Conversation

cjeanner
Copy link
Contributor

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@openshift-ci openshift-ci bot requested review from lewisdenny and psathyan May 15, 2024 05:52
@github-actions github-actions bot marked this pull request as draft May 15, 2024 05:52
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can verify d/s

@openshift-ci openshift-ci bot added the lgtm label May 15, 2024
@cjeanner cjeanner marked this pull request as ready for review May 15, 2024 05:57
@openshift-ci openshift-ci bot requested review from arxcruz and viroel May 15, 2024 05:57
@rebtoor
Copy link
Contributor

rebtoor commented May 15, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b3833cf into main May 15, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the reproducer/install-tools branch May 15, 2024 08:07
@raukadah
Copy link
Contributor

/approve
it works with the VA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants