Add redfish bmc protocol to BMH CR #1697
Conversation
Currently the connection string is set to `http://$IP:8000/redfish/v1/Systems/$UUID`, the BMH CR expects a bmc protocol of `ipmi, redfish or redfish-virtualmedia`. This patch adds the `cifmw_deploy_bmh_redfish_bmc_protocol` prefixed to the connection string if the connection type is `redfish` `cifmw_deploy_bmh_redfish_bmc_protocol` is set to `redfish-virtualmedia` by default to match [1] but is now configurable if needed. More details can be found [2] [3] [1] https://github.com/openstack-k8s-operators/install_yamls/blob/6f43dd716e8d1ab7b38926ca29c45699a874e164/devsetup/scripts/edpm-compute-baremetal.sh#L76C14-L76C35 [2] https://github.com/metal3-io/baremetal-operator/blob/b87793e1e394bbc4e4b93fda967e2ff9f1bbbe79/docs/api.md?plain=1#L37-L38 [3] https://book.metal3.io/quick-start.html?highlight=redfish-virtualmedia#create-baremetalhosts
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
| @@ -13,7 +13,7 @@ metadata: | |||
| workload: {{ node_name.split('-')[0] }} | |||
| spec: | |||
| bmc: | |||
| address: {{ node_data['connection'] }} | |||
| address: {{ cifmw_deploy_bmh_redfish_bmc_protocol ~ '+' if 'redfish' in node_data['connection'] }}{{ node_data['connection'] }} | |||
There was a problem hiding this comment.
We are using idrac in most of the DS hardware, this approach will blow the entire NFV job.
There was a problem hiding this comment.
I checked the D/S job and only seen ipmi addresses in the rendered bmh resource? If you could point me to a reference on Slack I would be grateful.
You're right though, this test is too broad and would affect anyone using redfish, I'll have a think and submit a revision, thanks :)
Currently the connection string is set to
http://$IP:8000/redfish/v1/Systems/$UUID, the BMH CR expects a bmc protocol ofipmi, redfish or redfish-virtualmedia.This patch adds the
cifmw_deploy_bmh_redfish_bmc_protocolprefixed to the connection string if the connection type isredfishcifmw_deploy_bmh_redfish_bmc_protocolis set toredfish-virtualmediaby default to match [1] but is now configurable if needed.More details can be found [2] [3]
[1] https://github.com/openstack-k8s-operators/install_yamls/blob/6f43dd716e8d1ab7b38926ca29c45699a874e164/devsetup/scripts/edpm-compute-baremetal.sh#L76C14-L76C35
[2] https://github.com/metal3-io/baremetal-operator/blob/b87793e1e394bbc4e4b93fda967e2ff9f1bbbe79/docs/api.md?plain=1#L37-L38
[3] https://book.metal3.io/quick-start.html?highlight=redfish-virtualmedia#create-baremetalhosts
As a pull request owner and reviewers, I checked that: