Add become in bootstrap-hypervisor.yml #1693
Conversation
|
Thanks for the PR! ❤️ |
| @@ -4,6 +4,7 @@ | |||
| _user: "{{ remote_user | default('zuul') }}" | |||
| tasks: | |||
| - name: Create user on remote host | |||
There was a problem hiding this comment.
sounds weird, since:
- the doc mentions "password(less) root access"
- that playbook is the one creating the rootless user + sudo
so basically.... you mostly don't use that playbook... ? I had the same reflection with a DS equivalent patch...
There was a problem hiding this comment.
The usecases are:
- you have a baremetal "cloud"
- you run nested virt in some cloud
... and the server you requested is provisioned - you are given access via the "cloud-user" of the image deployed. You have SSH access, you have sudo - but you cannot login as root.
It is possible to just use the cloud-user. But with that follows the editing of stuff in notes/chat with co-workers that uses the default zuul user.
There was a problem hiding this comment.
oh. ok. heh, makes sense.
Note that my own baremetal doesn't have "zuul" user - that's how I catch (many) issues with paths, facts and so on.
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/dc77c07ad927416f906a9259e76da6da ✔️ noop SUCCESS in 0s |
Let's not assume it is possible to login as root. Add's "become: true" to the tasks that require priviliges.
hjensas
force-pushed
the
bootstrap-no-root
branch
from
37463fa to
1c14f77
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3e138c1
into
openstack-k8s-operators:main
Let's not assume it is possible to login as root.
Add's "become: true" to the tasks that require priviliges.
As a pull request owner and reviewers, I checked that: