Move the config of ceph backends to a template file, gating++ #1666
Conversation
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1cfe208c7d5344eb8ee50051953d4062 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 48s |
tosky
force-pushed
the
ceph_backend_template
branch
from
e9b48f4 to
f6e6265
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1b9d59cbac2347a88613df076b864e5e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 27s |
tosky
force-pushed
the
ceph_backend_template
branch
4 times, most recently
from
4f78bc9 to
2ade0fa
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Use 'template' instead of 'copy' to generate the Kustomization which will be used to configure the services with ceph as backend. This is needed because, according the ansible documentation, "If you need variable interpolation in copied files, use the ansible.builtin.template module. Using a variable with the content parameter produces unpredictable results." https://docs.ansible.com/ansible/latest/collections/ansible/builtin/copy_module.html#synopsis Remove an old template, previously used for the same purpose, then removed and readded by mistake in a rebase. Finally, make sure that a job which deploys ceph with HCI and use all these files actually is triggered when these files are changed, and actually readd the HCI job to the pipeline used to test ci-framework itself.
tosky
force-pushed
the
ceph_backend_template
branch
from
2ade0fa to
585e1b6
Compare
|
Updated again to fix the name of the template file (which has been moved around in the meantime) in the zuul files list |
|
/lgtm |
openshift-merge-bot
bot
merged commit 9a42447
into
openstack-k8s-operators:main
Use 'template' instead of 'copy' to generate the Kustomization which will be used to configure the services with ceph as backend. This is needed because, according the ansible documentation, "If you need variable interpolation in copied files, use the ansible.builtin.template module. Using a variable with the content parameter produces unpredictable results." https://docs.ansible.com/ansible/latest/collections/ansible/builtin/copy_module.html#synopsis
Remove an old template, previously used for the same purpose, then removed and readded by mistake in a rebase.
Finally, make sure that a job which deploys ceph with HCI and use all these files actually is triggered when these files are changed, and actually readd the HCI job to the pipeline used to test ci-framework itself.
As a pull request owner and reviewers, I checked that: