Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass reproducer Job zuul-params.yml in tcib content provider #1664

Merged
merged 1 commit into from
May 9, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented May 9, 2024

ci/playbooks/tcib/tcib.yml depends on zuul vars to find out the ci-framework 01-bootstrap.yml path.

Otherwise the tcib reproducer content provider playbook fails with following error

2024-05-09 03:30:52,939 p=25285 u=zuul n=ansible | ERROR! Unable to look up a name or access an attribute in template string ({{
    [
      ansible_user_dir,
      zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir,
      'playbooks',
      '01-bootstrap.yml'
    ] | ansible.builtin.path_join

}}).
Make sure your variable name does not contain invalid characters like '-': join() argument must be str, bytes, or os.PathLike object, not 'AnsibleUndefined'. join() argument must be str, bytes, or os.PathLike object, not 'AnsibleUndefined'.

Passing reproducer Job zuul-params.yml fixes the issue.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

ci/playbooks/tcib/tcib.yml depends on zuul vars to find
out the ci-framework 01-bootstrap.yml path.

Otherwise the tcib reproducer content provider playbook fails with
following error
```
2024-05-09 03:30:52,939 p=25285 u=zuul n=ansible | ERROR! Unable to look up a name or access an attribute in template string ({{
    [
      ansible_user_dir,
      zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir,
      'playbooks',
      '01-bootstrap.yml'
    ] | ansible.builtin.path_join

}}).
Make sure your variable name does not contain invalid characters like '-': join() argument must be str, bytes, or os.PathLike object, not 'AnsibleUndefined'. join() argument must be str, bytes, or os.PathLike object, not 'AnsibleUndefined'.
```
Passing reproducer Job zuul-params.yml fixes the issue.

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
@openshift-ci openshift-ci bot requested review from katarimanojk and queria May 9, 2024 07:55
Copy link

github-actions bot commented May 9, 2024

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft May 9, 2024 07:55
@raukadah raukadah marked this pull request as ready for review May 9, 2024 15:39
@openshift-ci openshift-ci bot requested a review from son-vyas May 9, 2024 15:39
@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 9, 2024
@viroel
Copy link
Contributor

viroel commented May 9, 2024

/lgtm

makes sense

@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9d77c69 into main May 9, 2024
7 of 8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix_reproducer branch May 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants