DNM - Decouple uni07eta network stage from control plane stage

[dsariel]

No description provided.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dsariel
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/97e777d9b09249fa946ae391513df630

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-hci FAILURE in 3m 21s
❌ rhoso-architecture-validate-hci-adoption FAILURE in 3m 17s

[dsariel]

no need in this change according to the support matrix

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aa3a71b99cc74b4da617451f42be2cc8

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni07eta FAILURE in 4m 20s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3785f8440d30470d87f34695274330f5

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni07eta FAILURE in 5m 31s

[dsariel]

recheck

[dsariel]

@abays hi, where from network.tools.multus and network.network_name are coming from with relate to

https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/ci_gen_kustomize_values/templates/uni07eta/network-values/values.yaml.j2#L87?

This line is a suspect that

we have no

apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  labels:
    osp/net: octavia
    osp/net-attach-def-type: standard
  name: octavia
  namespace: openstack
spec:
  config: |
    {
      "cniVersion": "0.3.1",
      "name": "octavia",
      "type": "bridge",
      "bridge": "octbr",
      "ipam": {
        "type": "whereabouts",
        "range": "172.23.0.0/24",
        "routes":  [
           {
              "dst": "172.24.0.0/16",
             "gw": "172.23.0.150"
           }          ],
        "range_start": "172.23.0.30",
        "range_end": "172.23.0.70"
      }
    }
---

in logs/controller-0/ci-framework-data/artifacts/kustomize_deploy/network.yaml

[abays]

@abays hi, where from network.tools.multus and network.network_name are coming from with relate to

https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/ci_gen_kustomize_values/templates/uni07eta/network-values/values.yaml.j2#L87?

This line is a suspect that

we have no

apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  labels:
    osp/net: octavia
    osp/net-attach-def-type: standard
  name: octavia
  namespace: openstack
spec:
  config: |
    {
      "cniVersion": "0.3.1",
      "name": "octavia",
      "type": "bridge",
      "bridge": "octbr",
      "ipam": {
        "type": "whereabouts",
        "range": "172.23.0.0/24",
        "routes":  [
           {
              "dst": "172.24.0.0/16",
             "gw": "172.23.0.150"
           }          ],
        "range_start": "172.23.0.30",
        "range_end": "172.23.0.70"
      }
    }
---

in logs/controller-0/ci-framework-data/artifacts/kustomize_deploy/network.yaml

@dsariel I think the base source is this [1], but that is ingested by CIFMW and then goes through further refinement/processing before it is fed to the template you mentioned [2]. I am not familiar with the internal details of that CIFMW process though.

[1]

architecture/examples/dt/uni07eta/control-plane/nncp/values.yaml

Lines 160 to 183 in 32d7703

	octavia:
	dnsDomain: octavia.openstack.lab
	mtu: 1500
	vlan: 23
	base_iface: enp6s0
	net-attach-def: |
	{
	"cniVersion": "0.3.1",
	"name": "octavia",
	"type": "bridge",
	"bridge": "octbr",
	"ipam": {
	"type": "whereabouts",
	"range": "172.23.0.0/24",
	"range_start": "172.23.0.30",
	"range_end": "172.23.0.70",
	"routes": [
	{
	"dst": "172.24.0.0/16",
	"gw": "172.23.0.150"
	}
	]
	}
	}

[2] https://github.com/openstack-k8s-operators/ci-framework/blob/main/roles/ci_gen_kustomize_values/templates/uni07eta/network-values/values.yaml.j2#L87