Decouple uni06zeta network stage from control plane stage #487

fyanac · 2025-01-30T12:14:54Z

Also Add automation file for uni06zeta-adoption

openshift-ci · 2025-01-30T12:15:00Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fyanac
Once this PR has been reviewed and has the lgtm label, please assign leifmadsen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-01-30T12:15:05Z

Hi @fyanac. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tosky · 2025-01-30T13:56:18Z

automation/vars/uni06zeta-adoption.yaml

+      - path: examples/dt/uni06zeta/control-plane
+        wait_conditions:
+          - >-
+            oc -n openstack wait nncp


wait on nncp or wait on openstackcontrolplane ?

Thank you for your comment, I have to recheck it, because I was following the hci adoption -> https://github.com/openstack-k8s-operators/architecture/blob/main/automation/vars/hci-adoption.yaml

Uhm, I'm probably wrong on this, so feel free to ignore my comment

ciecierski · 2025-02-04T15:38:42Z

Check #489 to see how decoupling of control plane and networking should be done. For pre adoption steps we need only networking. Control plane is deployed during adoption procedure.

softwarefactory-project-zuul · 2025-02-04T22:55:56Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7ef3417a97e42b8a844bc64dfc2741c

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 4m 13s
❌ rhoso-architecture-validate-uni06zeta-adoption FAILURE in 5m 10s

softwarefactory-project-zuul · 2025-02-05T13:35:17Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1fc62fc4395f436cb8273b6fb7ec1221

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 5m 28s
❌ rhoso-architecture-validate-uni06zeta-adoption FAILURE in 5m 33s

softwarefactory-project-zuul · 2025-02-05T16:03:39Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2e04306f47c84720a5d1b2db52671807

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 4m 15s
❌ rhoso-architecture-validate-uni06zeta-adoption FAILURE in 4m 20s

softwarefactory-project-zuul · 2025-02-05T16:25:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bed1370f5d8d4ccaa8a97c8628498a7a

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 4m 27s
✔️ rhoso-architecture-validate-uni06zeta-adoption SUCCESS in 4m 19s

abays · 2025-02-05T16:37:03Z

automation/vars/uni06zeta-adoption.yaml

+      - path: examples/dt/uni06zeta/control-plane
+        wait_conditions:
+          - >-
+            oc -n metallb-system wait pod
+            -l app=metallb -l component=speaker
+            --for condition=Ready
+            --timeout=5m
+        values:
+          - name: network-values
+            src_file: networking/nncp/values.yaml
+          - name: service-values
+            src_file: service-values.yaml
+        build_output: control-plane.yaml


Suggested change

- path: examples/dt/uni06zeta/control-plane

wait_conditions:

- >-

oc -n metallb-system wait pod

-l app=metallb -l component=speaker

--for condition=Ready

--timeout=5m

values:

- name: network-values

src_file: networking/nncp/values.yaml

- name: service-values

src_file: service-values.yaml

build_output: control-plane.yaml

- path: examples/dt/uni06zeta/control-plane/networking

wait_conditions:

- >-

oc -n metallb-system wait pod

-l app=metallb -l component=speaker

--for condition=Ready

--timeout=5m

values:

- name: network-values

src_file: nncp/values.yaml

build_output: networking.yaml

Thank you for your comment

softwarefactory-project-zuul · 2025-02-05T16:39:42Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dfc33e6b6a174badbb3401d0973778d3

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 4m 20s
✔️ rhoso-architecture-validate-uni06zeta-adoption SUCCESS in 5m 46s

abays · 2025-02-05T16:39:47Z

examples/dt/uni06zeta/control-plane.md

This file should be modified to account for the new networking stage

softwarefactory-project-zuul · 2025-02-05T17:50:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c332c8d07b7e4f94b34359e2251e0252

✔️ noop SUCCESS in 0s
❌ rhoso-architecture-validate-uni06zeta FAILURE in 4m 13s
❌ rhoso-architecture-validate-uni06zeta-adoption FAILURE in 4m 27s

Also Add automation file for uni06zeta-adoption

openshift-ci bot added the do-not-merge/work-in-progress label Jan 30, 2025

openshift-ci bot added the needs-ok-to-test label Jan 30, 2025

fyanac force-pushed the zeta06_adoption branch from 5cad03f to 88ea2a3 Compare January 30, 2025 13:20

tosky reviewed Jan 30, 2025

View reviewed changes

fyanac force-pushed the zeta06_adoption branch from bc14d13 to e9e8a8c Compare February 5, 2025 13:29

fyanac force-pushed the zeta06_adoption branch from e9e8a8c to 1881bf5 Compare February 5, 2025 15:58

fyanac changed the title ~~Add automation file for uni06zeta-adoption.~~ Decouple uni06zeta network stage from control plane stage Feb 5, 2025

fyanac force-pushed the zeta06_adoption branch from 1881bf5 to 050c22e Compare February 5, 2025 16:20

fyanac force-pushed the zeta06_adoption branch from 050c22e to e1ea710 Compare February 5, 2025 16:33

abays reviewed Feb 5, 2025

View reviewed changes

examples/dt/uni06zeta/control-plane.md Outdated

Copy link

Contributor

abays Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be modified to account for the new networking stage

fyanac force-pushed the zeta06_adoption branch from e1ea710 to 062c140 Compare February 5, 2025 17:45

Decouple uni06zeta network stage from control plane stage

738c8f6

Also Add automation file for uni06zeta-adoption

fyanac force-pushed the zeta06_adoption branch from 062c140 to 738c8f6 Compare February 5, 2025 18:12

fyanac marked this pull request as ready for review February 10, 2025 13:16

openshift-ci bot removed the do-not-merge/work-in-progress label Feb 10, 2025

openshift-ci bot requested review from abays and fultonj February 10, 2025 13:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decouple uni06zeta network stage from control plane stage #487

Decouple uni06zeta network stage from control plane stage #487

fyanac commented Jan 30, 2025 •

edited

Loading

openshift-ci bot commented Jan 30, 2025

openshift-ci bot commented Jan 30, 2025

tosky Jan 30, 2025

fyanac Jan 30, 2025

tosky Jan 30, 2025

ciecierski commented Feb 4, 2025

softwarefactory-project-zuul bot commented Feb 4, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

abays Feb 5, 2025

fyanac Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

abays Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

Decouple uni06zeta network stage from control plane stage #487

Are you sure you want to change the base?

Decouple uni06zeta network stage from control plane stage #487

Conversation

fyanac commented Jan 30, 2025 • edited Loading

openshift-ci bot commented Jan 30, 2025

openshift-ci bot commented Jan 30, 2025

tosky Jan 30, 2025

Choose a reason for hiding this comment

fyanac Jan 30, 2025

Choose a reason for hiding this comment

tosky Jan 30, 2025

Choose a reason for hiding this comment

ciecierski commented Feb 4, 2025

softwarefactory-project-zuul bot commented Feb 4, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

softwarefactory-project-zuul bot commented Feb 5, 2025

abays Feb 5, 2025

Choose a reason for hiding this comment

fyanac Feb 5, 2025

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Feb 5, 2025

abays Feb 5, 2025

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Feb 5, 2025

fyanac commented Jan 30, 2025 •

edited

Loading