-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIDONE VA (ipv4) #245
Add PIDONE VA (ipv4) #245
Conversation
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). See openstack-k8s-operators/architecture#245
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). See openstack-k8s-operators/architecture#245
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/6bd4a12851184cdfb4bd2d8cc7875997 ✔️ noop SUCCESS in 0s |
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). See openstack-k8s-operators/architecture#245
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). Additionally, we need to expand networking-env-definition.yml to include additional workers. See openstack-k8s-operators/architecture#245
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0364dd1f8e514de1bd799691c8661403 ✔️ noop SUCCESS in 0s |
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). Additionally, we need to expand networking-env-definition.yml to include additional workers. See openstack-k8s-operators/architecture#245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create architecture/examples/va/pidone/README.md
and add basic instructions for someone to use to deploy the VA manually. For example, see architecture/examples/va/hci/README.md
. Once this is created please patch the main README to link to this it.
I did the following and the CRs look reasonable to me.
cd architecture/examples/va/pidone/
cd nncp
kustomize build . > nncp.yaml
cd ..
kustomize build . > control-plane.yaml
cd edpm/nodeset
kustomize build . > edpm.yaml
cd ../deployment
kustomize build . > deploy.yaml
This will need to be rebased (right now if I use it to build the HCI CRs they're missing the change from PR246).
I don't have any objections to this. I think it can be merged after a few issues raised above are addressed. |
f20b142
to
7e91364
Compare
I'm +2 to merge this. @abays or @leifmadsen are you OK with that? |
efec8d8
to
78861e5
Compare
This commit add a "PIDONE Validated Architecture" composed by: - 3 x ocp masters - 3 x ocp workers - 1 x testOperator-tainted ocp worker The additional workers are required so that we can perform disruptive tests simulating ocp failures (reboots/crashes/etc). Similarly, we need a special worker that would only run testoperator pods so that the tests will not be affected by the simulated infrastructure failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
Sorry, I won't have time today to review this thoroughly, but I trust you guys, so I'm +1 to see it merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Build failed (gate pipeline). For information on how to proceed, see https://review.rdoproject.org/zuul/buildset/e3cf71125b5e41c6895c1744f9886983 Warning: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fultonj, lmiccini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
1 similar comment
recheck |
New changes are detected. LGTM label has been removed. |
This isn't auto-merging despite having the |
Ah, it was the depends-on that was blocking it. Approving and merging the dependency now. |
This commit adds a scenario file with the parameters necessary to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers OpenShift cluster with network isolation (ipv4). Additionally, we need to expand networking-env-definition.yml to include additional workers. See openstack-k8s-operators/architecture#245
This commit add a "PIDONE Validated Architecture" composed by:
The workers are required so that we can perform disruptive tests simulating ocp failures (reboots/crashes/etc).
Similarly, we need a special worker that would only run testoperator pods so that the tests will not be affected by the simulated infrastructure failures.
Depends-On: openstack-k8s-operators/ci-framework#1752