Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIDONE VA (ipv4) #245

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

lmiccini
Copy link
Contributor

@lmiccini lmiccini commented May 23, 2024

This commit add a "PIDONE Validated Architecture" composed by:

  • 3 x ocp masters
  • 3 x ocp workers
  • 1 x testOperator-tainted ocp worker

The workers are required so that we can perform disruptive tests simulating ocp failures (reboots/crashes/etc).

Similarly, we need a special worker that would only run testoperator pods so that the tests will not be affected by the simulated infrastructure failures.

Depends-On: openstack-k8s-operators/ci-framework#1752

@openshift-ci openshift-ci bot requested review from fultonj and leifmadsen May 23, 2024 05:15
lmiccini added a commit to lmiccini/ci-framework that referenced this pull request May 23, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

See openstack-k8s-operators/architecture#245
lmiccini added a commit to lmiccini/ci-framework that referenced this pull request May 23, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

See openstack-k8s-operators/architecture#245
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6bd4a12851184cdfb4bd2d8cc7875997

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-pidone FAILURE in 6m 30s

lmiccini added a commit to lmiccini/ci-framework that referenced this pull request May 23, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

See openstack-k8s-operators/architecture#245
lmiccini added a commit to lmiccini/ci-framework that referenced this pull request May 23, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

Additionally, we need to expand networking-env-definition.yml to
include additional workers.

See openstack-k8s-operators/architecture#245
@lmiccini
Copy link
Contributor Author

recheck

Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0364dd1f8e514de1bd799691c8661403

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-pidone FAILURE in 4m 06s

@fultonj fultonj added validated-architecture Validated architecture changes or implementations ↟ priority-high High priority item that needs to be reviewed and testing in short order labels May 23, 2024
va/pidone/README.md Outdated Show resolved Hide resolved
lmiccini added a commit to lmiccini/ci-framework that referenced this pull request May 23, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

Additionally, we need to expand networking-env-definition.yml to
include additional workers.

See openstack-k8s-operators/architecture#245
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create architecture/examples/va/pidone/README.md and add basic instructions for someone to use to deploy the VA manually. For example, see architecture/examples/va/hci/README.md. Once this is created please patch the main README to link to this it.
I did the following and the CRs look reasonable to me.

cd architecture/examples/va/pidone/
cd nncp
kustomize build . > nncp.yaml
cd ..
kustomize build . > control-plane.yaml
cd edpm/nodeset
kustomize build . > edpm.yaml
cd ../deployment
kustomize build . > deploy.yaml

This will need to be rebased (right now if I use it to build the HCI CRs they're missing the change from PR246).

examples/va/pidone/edpm/deployment/kustomization.yaml Outdated Show resolved Hide resolved
@fultonj
Copy link
Contributor

fultonj commented May 23, 2024

I don't have any objections to this. I think it can be merged after a few issues raised above are addressed.

@lmiccini lmiccini force-pushed the pidone_va branch 3 times, most recently from f20b142 to 7e91364 Compare May 24, 2024 06:14
@fultonj
Copy link
Contributor

fultonj commented May 28, 2024

I'm +2 to merge this.

@abays or @leifmadsen are you OK with that?

@fultonj fultonj requested a review from abays May 28, 2024 11:15
automation/vars/pidone.yaml Outdated Show resolved Hide resolved
va/pidone/README.md Outdated Show resolved Hide resolved
@lmiccini lmiccini force-pushed the pidone_va branch 2 times, most recently from efec8d8 to 78861e5 Compare May 28, 2024 13:12
This commit add a "PIDONE Validated Architecture" composed by:

- 3 x ocp masters
- 3 x ocp workers
- 1 x testOperator-tainted ocp worker

The additional workers are required so that we can perform
disruptive tests simulating ocp failures (reboots/crashes/etc).

Similarly, we need a special worker that would only run
testoperator pods so that the tests will not be affected by
the simulated infrastructure failures.
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@abays
Copy link
Contributor

abays commented May 28, 2024

/approve

@leifmadsen
Copy link
Contributor

I'm +2 to merge this.

@abays or @leifmadsen are you OK with that?

Sorry, I won't have time today to review this thoroughly, but I trust you guys, so I'm +1 to see it merge.

@leifmadsen leifmadsen requested a review from fultonj May 28, 2024 16:59
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://review.rdoproject.org/zuul/buildset/e3cf71125b5e41c6895c1744f9886983

Warning:
Change 1752 in project openstack-k8s-operators/ci-framework does not share a change queue with 245 in project openstack-k8s-operators/architecture

Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fultonj, lmiccini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fultonj fultonj removed the request for review from leifmadsen May 28, 2024 17:18
@abays
Copy link
Contributor

abays commented May 28, 2024

recheck

1 similar comment
@abays
Copy link
Contributor

abays commented May 28, 2024

recheck

@openshift-ci openshift-ci bot removed the lgtm label May 28, 2024
Copy link

openshift-ci bot commented May 28, 2024

New changes are detected. LGTM label has been removed.

@abays abays added the lgtm label May 28, 2024
@abays
Copy link
Contributor

abays commented May 29, 2024

This isn't auto-merging despite having the approved and lgtm labels, so I am going to manually do it.

@abays abays merged commit 5c4b8e2 into openstack-k8s-operators:main May 29, 2024
8 checks passed
@abays
Copy link
Contributor

abays commented May 29, 2024

Ah, it was the depends-on that was blocking it. Approving and merging the dependency now.

openshift-merge-bot bot pushed a commit to openstack-k8s-operators/ci-framework that referenced this pull request May 29, 2024
This commit adds a scenario file with the parameters necessary
to deploy the "PIDONE VA", consisting in a 3 masters + 4 workers
OpenShift cluster with network isolation (ipv4).

Additionally, we need to expand networking-env-definition.yml to
include additional workers.

See openstack-k8s-operators/architecture#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ↟ priority-high High priority item that needs to be reviewed and testing in short order validated-architecture Validated architecture changes or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants