Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 controlplane with Ironic DT #168

Closed
wants to merge 2 commits into from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Apr 8, 2024

No description provided.

@hjensas hjensas force-pushed the ipv6-osprh-5137 branch 14 times, most recently from a9137ff to 85de8a0 Compare April 12, 2024 12:27
@hjensas hjensas changed the title [WIP] Add IPv6 controlplane with Ironic DT Add IPv6 controlplane with Ironic DT Apr 12, 2024
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@leifmadsen leifmadsen added deployment-topology Deployment topology changes or implementations needs-testing Testing proof is required prior to merge ↟ priority-high High priority item that needs to be reviewed and testing in short order labels Apr 29, 2024
@fultonj
Copy link
Contributor

fultonj commented Apr 29, 2024

@hjensas This looks good. Can you confirm it's been tested?

@leifmadsen leifmadsen added the needs-automation Requires implementation of automated testing label Apr 29, 2024
@fultonj
Copy link
Contributor

fultonj commented Apr 30, 2024

could this be rebased?

Co-authored-by: Andrew Bays <andrew.bays@protonmail.com>
@hjensas hjensas marked this pull request as draft July 4, 2024 06:39
@hjensas
Copy link
Contributor Author

hjensas commented Jul 4, 2024

Closing this, replaced by - #319

@hjensas hjensas closed this Jul 4, 2024
@hjensas hjensas mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-topology Deployment topology changes or implementations do-not-merge/work-in-progress needs-automation Requires implementation of automated testing needs-testing Testing proof is required prior to merge ↟ priority-high High priority item that needs to be reviewed and testing in short order
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants