Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muscles (GeometryPaths) need end-caps #68

Closed
2 of 12 tasks
aseth1 opened this issue Jul 18, 2017 · 3 comments
Closed
2 of 12 tasks

Muscles (GeometryPaths) need end-caps #68

aseth1 opened this issue Jul 18, 2017 · 3 comments

Comments

@aseth1
Copy link
Member

aseth1 commented Jul 18, 2017

Currently GeometryPaths are drawn as smooth tubes, but they are open. They should be capped either by a sphere at each end or by tapering the skinned mesh.

Here is an example of what it looks like:
opensim_open_cylinder

Three.js version
  • Dev
  • r77
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@aseth1
Copy link
Member Author

aseth1 commented Jul 18, 2017

@tkuchida in a brief discussion with @aymanhab he mentioned preferring not to introduce additional geometry (i.e. spheres) and use the skinning of the cylinders to create a taper at each end.

@tkuchida
Copy link
Member

in a brief discussion with @aymanhab he mentioned preferring not to introduce additional geometry (i.e. spheres) and use the skinning of the cylinders to create a taper at each end.

Sounds fine. I just don't think users should be able to see the inside of the muscle cylinder; how that's implemented isn't as important.

@aymanhab
Copy link
Member

fixed years ago, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants