Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease log level for NaN parsing #3998

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

alexbeattie42
Copy link
Contributor

@alexbeattie42 alexbeattie42 commented Jan 27, 2025

Decrease the log level for NaN parsing. When I originally implemented this I thought this is a rare occurrence or indicative of a typo (ex 0 vs. O). After working with .trc files I now see that NaN values are very prevalent and logging a warning every time you try to parse one makes the log output unusable. This drops the log level to debug so you can get the output if you want but it doesn't spam the logs for regular usage.

@nickbianco can you take a look?

CHANGELOG.md (choose one)

  • no need to update

This change is Reviewable

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nickbianco nickbianco merged commit bcbfa95 into opensim-org:main Jan 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants