Decrease log level for NaN parsing #3998
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease the log level for NaN parsing. When I originally implemented this I thought this is a rare occurrence or indicative of a typo (ex
0
vs.O
). After working with.trc
files I now see thatNaN
values are very prevalent and logging a warning every time you try to parse one makes the log output unusable. This drops the log level to debug so you can get the output if you want but it doesn't spam the logs for regular usage.@nickbianco can you take a look?
CHANGELOG.md (choose one)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)