Use Simbody's native PolygonalMesh rather than stale copy #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle SimTK::String for pathname
|
Since API for polygonalMesh has changed we needed either to update the local copy of PolygonalMesh or use the latest from simbody. Opted to the latter to reduce the hacked local copies of simbody headers. |
aymanhab
requested review from
adamkewley
and removed request for
nickbianco
|
Thanks @nickbianco |
alexbeattie42
pushed a commit
to gateway240/opensim-core
that referenced
this pull request
Jan 18, 2025
…g#3972) * Use Simbody's native PolygonalMesh rather than the old proxy we used in opensim-core * Add method that takes normal String to workaround swig failure to handle SimTK::String for pathname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #0
Brief summary of changes
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is