Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNI][4.14] fix commit check #206

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

ffromani
Copy link
Member

@ffromani ffromani commented Jun 4, 2024

The env var COMMITS may be empty. Handle it accordingly.

Signed-off-by: Francesco Romani fromani@redhat.com
(cherry picked from commit 1912798)

@openshift-ci openshift-ci bot requested review from MarSik and yanirq June 4, 2024 07:59
Copy link

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@ffromani
Copy link
Member Author

ffromani commented Jun 4, 2024

/close

@openshift-ci openshift-ci bot closed this Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

@ffromani: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ffromani
Copy link
Member Author

ffromani commented Jun 4, 2024

/reopen

@openshift-ci openshift-ci bot reopened this Jun 4, 2024
Copy link

openshift-ci bot commented Jun 4, 2024

@ffromani: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The env var `COMMITS` may be empty. Handle it accordingly.

Signed-off-by: Francesco Romani <fromani@redhat.com>
(cherry picked from commit 68af65c)
@ffromani ffromani force-pushed the fix-commit-check-4.14 branch from cdb31d2 to 61bbff4 Compare June 4, 2024 08:49
Copy link

openshift-ci bot commented Jun 4, 2024

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 61bbff4 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani
Copy link
Member Author

ffromani commented Jun 4, 2024

unrelated CI failure

@ffromani ffromani merged commit 3b8d5b9 into release-4.14 Jun 4, 2024
5 of 7 checks passed
@ffromani ffromani deleted the fix-commit-check-4.14 branch June 4, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant