Resync 20240529 #200
Merged
Resync 20240529 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix log print and some nit issue
"host-level" resources are resources which are not expected to have NUMA affinity. This means that these resources not showing up in per-NUMA resource counters should not prevent per se scheduling on a given node. Signed-off-by: Francesco Romani <fromani@redhat.com>
We call "NUMA-affine" resources compute resources like CPU and memory/hugepages which we know they do expose NUMA affinity. This is another attempt to factor this logic in a central place. Signed-off-by: Francesco Romani <fromani@redhat.com>
…sources [noderesourcetopology] improve classification of resources
Problem: the comment and associated docs should say if there are not resources available needed for the group, the scheduler should not start any. Solution: update all references anyone->any. It could also be stated "not start any one" but "not start any" is a more natural way to say it Signed-off-by: vsoch <vsoch@users.noreply.github.com>
so that we can use site as chart repo Signed-off-by: Wei Zhang <kweizh@gmail.com>
site: add chart index to site
Add ARG for base image customization
* add crd(podgroup, elasticquotas) field * fix: crd field type Signed-off-by: googs1025 <googs1025@gmail.com> --------- Signed-off-by: googs1025 <googs1025@gmail.com>
Fix CVE-2023-47108 in go.opentelemetry.io
Signed-off-by: googs1025 <googs1025@gmail.com>
This reverts commit 99de67d.
docs: anyone should be any
replace deprecated method
Signed-off-by: Xiaodong Ye <yeahdongcn@gmail.com>
Fix typo: gochache => gocache
…-gen bump codegen to 0.14.0
before kubernetes-sigs#710 and kubernetes-sigs#725, we logged the container being processed alongside the pod (identified by namespace/name pair). It was dropped by mistake and not deliberately. This is useful information when troubleshooting, so let's add it back. Signed-off-by: Francesco Romani <fromani@redhat.com>
The ephemeral storage resource is not a deciding factor for noderesourcetopology filtering, but it was incorrectly accounted causing bad scheduling decisions. First, we add some integration test coverage to catch these issues. Signed-off-by: Francesco Romani <fromani@redhat.com>
Rewrite the accounting of NUMA-local resources when using scope=container. The previous code was too lenient and worked mostly by side effects when dealing with non-NUMA affine resources. A non-NUMA affine resource (aka a hostlevel resource) is a resource which is not guaranteed to always have a NUMA affinity. CPU and memory (incl. hugepages) always do, but devices may or may not, both options are legal for device plugins. Similarly, ephemeral storage is a prominent example of resource which should never have a NUMA affinity. The accounting in this case was wrong because previously the resource was considered NUMA affine. Note: it's legal to configure topology updaters (e.g. NFD) to not advertise CPU and memory in NRT objects. Thus is best to treat lack of them as warnings, not as blocking errors. However if the per-NUMA affine counters go negative this is definitely an error condition we need to detect and be very loud about it. Signed-off-by: Francesco Romani <fromani@redhat.com>
plugin.go should contain only entry point and orchestration code. Let's move all the utilties and logic to other source code files. Trivial code movement with minimal renames. Signed-off-by: Francesco Romani <fromani@redhat.com>
[noderesourcetopology] rewrite accounting of numa-affine resources with scope=container
Signed-off-by: Francesco Romani <fromani@redhat.com>
openshift-ci
bot
added
the
approved
Signed-off-by: Francesco Romani <fromani@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, Tal-or The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync with the tip of the upstream master branch
consume the new ephemeral storage fixes