resync 20240507 #196
Merged
resync 20240507 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cathy Zhang <cathy.h.zhang@intel.com> Signed-off-by: Theresa <theresa.shan@intel.com>
Co-authored-by: Cathy Zhang <cathy.h.zhang@intel.com> Signed-off-by: Theresa <theresa.shan@intel.com>
Fix wrong highlight in diff code block
Remove incorrect Pod name from installation doc
remove manual edit strings from crd manifests
Disk IO Aware Scheduling KEP
Fix diff code block highlight color, change the format of yaml diff code block from raw diff to git diff.
Manually update the API files for the implementation of SySched, a system call-aware scheduler(KEP kubernetes-sigs#399). SySched is a new scoring plugin that ranks feasible nodes based on the relative risks of pods' system call usage.
Sysched: add the implementation of SySched
…ng_op_helm Add scheduling op to helm chart
bump k8s deps to v1.28.8
[CVE-2023-45288] Bump x/net to v0.23.0
Documents update for release v0.28.8
…rf-fix Avoid unnecessary requeue operations in coscheduling
Documents update for release v0.28.9
bump k8s deps to v1.29 on master
Bump NRT API package to v0.1.2; there is no API change, but we have now a better replacement for the internal `getID` helper, which we can now remove. Signed-off-by: Francesco Romani <fromani@redhat.com>
Move to the logr.Logger interface everywhere, instead of the global `klog` instance. This enable named logger, presetting values for simple and automatic consistency, enables pluggable loggers and comes for free since we already depend on the logr package and klog has a native logr integration. In addition, add minimal support to make it easy to replace the logr reference, to help integrators of this code. The default is still (and will still be) klog for backward compatibility and ecosystem integration. Signed-off-by: Francesco Romani <fromani@redhat.com>
[noderesourcetopology] move logging to the logr interface
pass existing context without using TODO()
After more review and conversations, we have a better understanding of how integration with contextual logging should loom like. First and foremost, injecting loggers would conflict with the very goals of contextual logging. So, let's drop this code we added in kubernetes-sigs#710. The contextual logger doesn't do key/values deduplication. This is let to (some) backends. To avoid log clutter, trim down the extra key/value pairs and add only those we really need to ensure a good troubleshooting experience. Still let's make sure to add critical key/value pairs in the relevant entries, at cost of a possible duplication. When reporting the current assumed resources, the current representation is neither concise nor very human friendly. Additionally, multi-line log entries are harder to process and should be avoided. So let's move to a more concise representation, which turns out not obviously less human friendly and is no longer multiline. Review verbosiness of log entries. Move down to verbose=2 logs which are really key to understand the behavior. We should set a hard limit to log entries to minimize the log spam while keeping at least some observability without requiring v=4 or greater. The level v=4 is usually/often the highest-not-spammy log. When debug logs are needed we often set v=4, and higher verbosity levels are often used only in desperate times. Thus, promote to v=4 the debug logs we should really see. Everywhere else in the kubernetes ecosystem, and most notably in the scheduler, the pod namespace/name pair is called "pod", while we called it "logID". We do it to use the same name for all the flows, being the cache resync (which is driven by time, not by an object) the odd one. It seems better to be externally consistent (with the ecosystem) rather than internally consistent (all the flows in the same plugin), so we rename "logID" to "pod" in the log entries. Signed-off-by: Francesco Romani <fromani@redhat.com>
…logging [noderesourcetopology] complete the contextual logging integration
This reverts commit 252884d.
This reverts commit e7045bc.
This reverts commit 2b0c280.
resync to the tip of the main u/s branch Signed-off-by: Francesco Romani <fromani@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Update the plugins to conform to the newer APIs The v1beta3 was removed Signed-off-by: Francesco Romani <fromani@redhat.com>
|
depends on openshift-kni/numaresources-operator#933 |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cc @shajmakh |
|
/hold cancel dependency merged |
openshift-ci
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resync with the tip of the upstream master branch
we can now drop our KNI-specific dep bump, they are done by u/s