Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12][KNI] build: envtest: remove 'latest' floating tag refs #190

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

ffromani
Copy link
Member

never use floating tags in the build system, not
even for CI tests. Always pin explicit versions.

Signed-off-by: Francesco Romani fromani@redhat.com
(cherry picked from commit 3326b7a)

@openshift-ci openshift-ci bot requested review from swatisehgal and yanirq April 16, 2024 12:45
Copy link

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
never use floating tags in the build system, not
even for CI tests. Always pin explicit versions.

Signed-off-by: Francesco Romani <fromani@redhat.com>
(cherry picked from commit 3326b7a)
@ffromani ffromani force-pushed the drop-latest-tag-4.12 branch from 74e3114 to e98dbc7 Compare April 16, 2024 12:46
@ffromani ffromani merged commit 9c3ba06 into release-4.12 Apr 16, 2024
5 of 6 checks passed
@ffromani ffromani deleted the drop-latest-tag-4.12 branch April 16, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant