[Backport 2.x] Generate GetSnapshot (#1299) #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogesako
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli,
VachaShah and
Xtansia
as code owners
hogesako
changed the title
reta
reviewed
Dec 4, 2024
| public final int total() { | ||
| return this.total; | ||
| return 0; |
There was a problem hiding this comment.
May be:
Suggested change
| return 0; | |
| return snapshots().size(); |
There was a problem hiding this comment.
Could also rather than removing the fields just make them optional, and just have the minor "breakage"/inconvenience of them going from int to Integer
|
Please also run |
hogesako
force-pushed
the
backport/backport-1299-to-2.x
branch
from
989cfc2 to
deb52b6
Compare
reta
reviewed
Dec 5, 2024
| public final List<InfoFeatureState> featureStates() { | ||
| return this.featureStates; | ||
| return new ArrayList<>(); |
There was a problem hiding this comment.
Super nit:
Suggested change
| return new ArrayList<>(); | |
| return Collections.emptyList(); |
There was a problem hiding this comment.
Or just delete it as well, since it was not supported anyway
* Generate get snapshot Signed-off-by: Tatsuya Kawakami <43780506+hogesako@users.noreply.github.com> * add changelog Signed-off-by: Tatsuya Kawakami <43780506+hogesako@users.noreply.github.com> * Update codegen Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Tatsuya Kawakami <43780506+hogesako@users.noreply.github.com> Signed-off-by: Thomas Farr <tsfarr@amazon.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 1c7c6e0)
hogesako
force-pushed
the
backport/backport-1299-to-2.x
branch
from
deb52b6 to
2929787
Compare
reta
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #1299 to
2.xPlease review to ensure compatibility is maintained.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.