Skip to content

Fix testAddReplicaWhileWritesBlocked test under SegmentReplicationWithRemoteStorePressureIT #18067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

shourya035
Copy link
Member

Description

Fix for SegmentReplicationWithRemoteStorePressureIT#testAddReplicaWhileWritesBlocked. Test was failing at around 3000 iterations with primary and replica doc count mismatch.

Increased assertBusy check to 2 minutes from 1 minutes. After this change, test has been running for over 8000 iterations without failing.

Related Issues

Resolves #[14330]

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@ashking94
Copy link
Member

@shourya035 without this change, how soon does the test fails?

Copy link
Contributor

❌ Gradle check result for a1830f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shourya035
Copy link
Member Author

@shourya035 without this change, how soon does the test fails?

With 1 minute wait on assertBusy this fails after 3000 runs. With this, 8000+ and still going.

Copy link
Contributor

❌ Gradle check result for a1830f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Copy link
Contributor

✅ Gradle check result for 7dedb6f: SUCCESS

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (d3eb8fe) to head (7dedb6f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18067      +/-   ##
============================================
- Coverage     72.53%   72.51%   -0.03%     
- Complexity    67132    67155      +23     
============================================
  Files          5474     5474              
  Lines        310173   310174       +1     
  Branches      45066    45066              
============================================
- Hits         224993   224916      -77     
- Misses        66840    66856      +16     
- Partials      18340    18402      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashking94 ashking94 merged commit 5d308e0 into opensearch-project:main Apr 28, 2025
31 checks passed
@shourya035 shourya035 deleted the fix-14330 branch April 28, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants