Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements #52

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Enhancements #52

merged 9 commits into from
Aug 26, 2024

Conversation

AHReccese
Copy link
Member

@AHReccese AHReccese commented Aug 19, 2024

Reference Issues/PRs

#53

  • fulfill samples in README.md (CLI + Programmatically)

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese added the enhancement New feature or request label Aug 19, 2024
@AHReccese AHReccese added this to the reserver v0.3 milestone Aug 19, 2024
@AHReccese AHReccese self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (d71d7d3) to head (9b5954b).
Report is 80 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev      #52       +/-   ##
===========================================
- Coverage   82.76%   69.95%   -12.81%     
===========================================
  Files           5        6        +1     
  Lines          87      183       +96     
  Branches       10       37       +27     
===========================================
+ Hits           72      128       +56     
- Misses          6       40       +34     
- Partials        9       15        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AHReccese AHReccese marked this pull request as ready for review August 19, 2024 17:32
@AHReccese
Copy link
Member Author

After this PR, I will push the release PR. So let me know if you want to apply anything else before v0.3 release.
@sepandhaghighi

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese Take a look at my comments 🔥

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AHReccese AHReccese linked an issue Aug 23, 2024 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
@AHReccese AHReccese added the bug Something isn't working label Aug 24, 2024
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 6b513aa into dev Aug 26, 2024
42 checks passed
@sepandhaghighi sepandhaghighi deleted the enhancements branch August 26, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File path that contains space
2 participants