Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to fulfill template setup.py parameters #12

Closed
AHReccese opened this issue Feb 13, 2024 · 4 comments · Fixed by #55
Closed

ability to fulfill template setup.py parameters #12

AHReccese opened this issue Feb 13, 2024 · 4 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AHReccese
Copy link
Member

AHReccese commented Feb 13, 2024

Description

  • description
  • author
  • author email
  • URL
  • download URL
  • source
  • license
@AHReccese AHReccese added the enhancement New feature or request label Feb 13, 2024
@AHReccese AHReccese added this to the Reserver v0.2 milestone Feb 13, 2024
@AHReccese AHReccese self-assigned this Feb 13, 2024
@AHReccese
Copy link
Member Author

Since it is too fine-grained edition, I think it is better to just have it in Python usage (and not in the CLI usage).
By passing a dictionary that contains the fulfillment of the above attributes.
Do you agree? let me know so I can plan this out.
@sepandhaghighi

@sepandhaghighi
Copy link
Member

I believe this issue can be easily handled by using a JSON file in CLI mode.
In Python, converting JSON to a dictionary and vice versa is very straightforward.

@AHReccese
Copy link
Member Author

AHReccese commented Jun 21, 2024

OK, I will do this. why not.
Then the user is supposed to pass a JSON file.

but using only one config file when reserving a batch of names right?
@sepandhaghighi

@AHReccese
Copy link
Member Author

Answer: Either one config file or per name config file.

@AHReccese AHReccese linked a pull request Aug 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants