Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/limit gh action run #58

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Add/limit gh action run #58

merged 2 commits into from
Oct 23, 2024

Conversation

AHReccese
Copy link
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

Local tests on OSs

  • macOS
    • Sonoma
  • Windows
    • Windows 11
  • Linux
    • Ubuntu 20.04

@AHReccese AHReccese added the enhancement New feature or request label Oct 23, 2024
@AHReccese AHReccese added this to the nava v0.8 milestone Oct 23, 2024
@AHReccese AHReccese self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (1a4d99c) to head (3295bf2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #58   +/-   ##
=======================================
  Coverage   95.30%   95.30%           
=======================================
  Files           4        4           
  Lines         170      170           
  Branches       24       24           
=======================================
  Hits          162      162           
  Misses          2        2           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since It's a change on GitHub actions and does not include functional change I think we don't need tests on OSs.

@sadrasabouri sadrasabouri merged commit 7c8b493 into dev Oct 23, 2024
44 checks passed
@sadrasabouri sadrasabouri deleted the add/limit_gh_action_run branch October 23, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants