Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve figures #77

Merged
merged 7 commits into from
Dec 3, 2024
Merged

Conversation

milanwiedemann
Copy link
Member

@milanwiedemann milanwiedemann commented Dec 2, 2024

Make improvements to code structure in reports/pharmacy_first_report.Rmd and figures for presentation later today,

Code

Recator report and modularize loading data:

  • lib/functions/load_opensafely_outputs.R
  • lib/functions/load_validation_data.R

Figures

  • Improving clarity using more descriptive (facet)titles (e.g., OpenSAFELY now says OpenSAFELY-TPP)
  • Improve colour palettes to be colour blind friendly
  • Improve width/size to improve clarity

This will improve readability and modularity and make it easier for us to make further changes later on. It's only a start, there's much more we could do.
@milanwiedemann milanwiedemann force-pushed the milanwiedemann/updates-for-presentation branch from 792f74e to aacb97e Compare December 2, 2024 11:04
@milanwiedemann milanwiedemann marked this pull request as ready for review December 2, 2024 11:10
@milanwiedemann milanwiedemann merged commit d23e050 into main Dec 3, 2024
1 check passed
@milanwiedemann milanwiedemann deleted the milanwiedemann/updates-for-presentation branch December 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants