Viv3ckj/update viz #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanwiedemann
approved these changes
Oct 8, 2024
| @@ -93,7 +121,7 @@ Links to the codelist for each analysis can be found beneath the relevant sectio | |||
|
|
|||
| ### Total population | |||
|
|
|||
| ```{r, message=FALSE, warning=FALSE, fig.height=4, fig.width=4} | |||
| ```{r, message=FALSE, warning=FALSE} | |||
There was a problem hiding this comment.
I think we should keep this? it makes sure all the panels are roughly the same size? or what was your reason for removing this?
There was a problem hiding this comment.
There was an issue with the titles and axes being cropped out
| @@ -220,7 +260,7 @@ Here we show the number of consultations for each of the Pharmacy First Clinical | |||
|
|
|||
| ### Total population | |||
|
|
|||
| ```{r, message=FALSE, warning=FALSE, fig.height=4, fig.width=4} | |||
Comment on lines
+71
to
+94
| df_measures$ethnicity <- factor( | ||
| df_measures$ethnicity, | ||
| levels = c("White", "Mixed", "Asian or Asian British", | ||
| "Black or Black British", "Chinese or Other Ethnic Groups", | ||
| "Missing"), | ||
| ordered = TRUE | ||
| ) | ||
|
|
||
| df_measures$age_band <- factor( | ||
| df_measures$age_band, | ||
| levels = c("0-19", "20-39", "40-59", | ||
| "60-79", "80+", | ||
| "Missing"), | ||
| ordered = TRUE | ||
| ) | ||
|
|
||
| df_measures$region <- factor( | ||
| df_measures$region, | ||
| levels = c("East", "East Midlands", "London", | ||
| "North East", "North West", "South East", | ||
| "South West", "West Midlands", "Yorkshire and The Humber", | ||
| "Missing"), | ||
| ordered = TRUE | ||
| ) |
There was a problem hiding this comment.
this does what we want, but it would be could do this as one call using mutate. at some later point we should integrate this into the tidy_measures() function, for now I think it's ok if we do this outside of the function.
df_measures <- df_measures %>%
mutate(
ethnicity = factor(ethnicity, ...),
region = factor(region, ...),
age_band = factor(age_band, ...),
sex = factor(sex, ...)
)
Add ethnicity_from_sus codes for missing ethnicities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
Updated graphs with new colours, and correctly ordered values (only for region, ethnicity and age).
Would be good to see how the report with real data looks to get an idea on how to improve clarity, but should be okay for now.