Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish ChangeDefaultKeyStore to only apply to Java 11 #670

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Polish ChangeDefaultKeyStore to only apply to Java 11 #670

merged 1 commit into from
Feb 4, 2025

Conversation

timtebeek
Copy link
Contributor

What's changed?

  • Only apply to projects using Java 11 at the moment that we run the recipe.
  • Ensure there are spaces between string concatenations in the description.
  • Use the existing MethodMatcher in the Precondition as well.
  • Extract a constant for a repeated test text block.
  • Use more descriptive test method names.

What's your motivation?

Projects using Java 17+ should not revert to an older default value.

Anything in particular you'd like reviewers to focus on?

Hope you agree with the changes here; I think it's best to get this in before a release.

Any additional context

@timtebeek timtebeek added the bug Something isn't working label Feb 4, 2025
@timtebeek timtebeek self-assigned this Feb 4, 2025
MBoegers
MBoegers approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@MBoegers MBoegers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing..

@timtebeek timtebeek merged commit e9d71c5 into main Feb 4, 2025
2 checks passed
@timtebeek timtebeek deleted the polish-ChangeDefaultKeyStore branch February 4, 2025 17:31
ranuradh
ranuradh approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ranuradh ranuradh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates Tim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBoegers MBoegers MBoegers approved these changes

@ranuradh ranuradh ranuradh approved these changes

Assignees

@timtebeek timtebeek

Labels
bug Something isn't working
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timtebeek @MBoegers @ranuradh