-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds recipe for migration of @LazyCollection (#17)
* Adds recipe for migration of @LazyCollection @LazyCollection is deprecated since Hibernate 6.2 Added a recipe which removes the annotation and sets the fetch type in jakarta.persistence annotations instead. * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Revert "Apply suggestions from code review" This reverts commit fff71fc. * Minimize text block indentation and add code highlighting * Add precondition to limit recipe applicability * No need to finalize local fields * Remove need to construct J.FieldAccess * Use `FindAnnotation` and `RemoveAnnotationVisitor` * Apply suggestions from code review * Eliminates jakarta.persistence-api runtime dependency * At least set type correctly --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tim te Beek <tim@moderne.io> Co-authored-by: Tim te Beek <timtebeek@gmail.com>
- Loading branch information
1 parent
ea11d8c
commit 1fd6c84
Showing
3 changed files
with
641 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
145 changes: 145 additions & 0 deletions
145
src/main/java/org/openrewrite/hibernate/ReplaceLazyCollectionAnnotation.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
/* | ||
* Copyright 2024 the original author or authors. | ||
* <p> | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* <p> | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* <p> | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.openrewrite.hibernate; | ||
|
||
import org.openrewrite.ExecutionContext; | ||
import org.openrewrite.Preconditions; | ||
import org.openrewrite.Recipe; | ||
import org.openrewrite.TreeVisitor; | ||
import org.openrewrite.internal.ListUtils; | ||
import org.openrewrite.java.AnnotationMatcher; | ||
import org.openrewrite.java.JavaIsoVisitor; | ||
import org.openrewrite.java.JavaTemplate; | ||
import org.openrewrite.java.RemoveAnnotationVisitor; | ||
import org.openrewrite.java.search.FindAnnotations; | ||
import org.openrewrite.java.search.UsesType; | ||
import org.openrewrite.java.tree.*; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
||
public class ReplaceLazyCollectionAnnotation extends Recipe { | ||
@Override | ||
public String getDisplayName() { | ||
return "Replace `@LazyCollection` with `jakarta.persistence.FetchType`"; | ||
} | ||
|
||
@Override | ||
public String getDescription() { | ||
return "Adds the `FetchType` to jakarta annotations and deletes `@LazyCollection`."; | ||
} | ||
|
||
@Override | ||
public TreeVisitor<?, ExecutionContext> getVisitor() { | ||
return Preconditions.check(new UsesType<>("org.hibernate.annotations.LazyCollection", true), new JavaIsoVisitor<ExecutionContext>() { | ||
@Override | ||
public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) { | ||
maybeRemoveImport("org.hibernate.annotations.LazyCollection"); | ||
maybeRemoveImport("org.hibernate.annotations.LazyCollectionOption"); | ||
return super.visitCompilationUnit(cu, ctx); | ||
} | ||
|
||
@Override | ||
public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) { | ||
J.MethodDeclaration j = removeLazyCollectionAnnotation(method, ctx); | ||
return super.visitMethodDeclaration(j, ctx); | ||
} | ||
|
||
@Override | ||
public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations multiVariable, | ||
ExecutionContext ctx) { | ||
J.VariableDeclarations j = removeLazyCollectionAnnotation(multiVariable, ctx); | ||
return super.visitVariableDeclarations(j, ctx); | ||
} | ||
|
||
@Override | ||
public J.Annotation visitAnnotation(J.Annotation annotation, ExecutionContext ctx) { | ||
J.Annotation ann = super.visitAnnotation(annotation, ctx); | ||
|
||
JavaType annType = ann.getType(); | ||
if (!(TypeUtils.isOfClassType(annType, "jakarta.persistence.ElementCollection") || | ||
TypeUtils.isOfClassType(annType, "jakarta.persistence.OneToOne") || | ||
TypeUtils.isOfClassType(annType, "jakarta.persistence.OneToMany") || | ||
TypeUtils.isOfClassType(annType, "jakarta.persistence.ManyToOne") || | ||
TypeUtils.isOfClassType(annType, "jakarta.persistence.ManyToMany"))) { | ||
// recipe does not apply | ||
return ann; | ||
} | ||
|
||
List<Expression> currentArgs = ann.getArguments(); | ||
|
||
// Do not update existing fetch value | ||
if (currentArgs != null && currentArgs.stream() | ||
.filter(arg -> arg instanceof J.Assignment) | ||
.map(J.Assignment.class::cast) | ||
.anyMatch(arg -> ((J.Identifier) arg.getVariable()).getSimpleName().equals("fetch"))) { | ||
return ann; | ||
} | ||
|
||
// Retrieve FetchType set from LazyCollectionOption | ||
String fetchType = getCursor().getNearestMessage("fetchType"); | ||
if (fetchType == null) { | ||
// no mapping found | ||
return ann; | ||
} | ||
|
||
maybeAddImport("jakarta.persistence.FetchType", false); | ||
J.Annotation annotationWithFetch = JavaTemplate.builder("fetch = " + fetchType) | ||
.imports("jakarta.persistence.FetchType") | ||
.contextSensitive() | ||
.build() | ||
.apply(getCursor(), ann.getCoordinates().replaceArguments()); | ||
JavaType fetchTypeType = JavaType.buildType("jakarta.persistence.FetchType"); | ||
J.Assignment assignment = (J.Assignment) annotationWithFetch.getArguments().get(0); | ||
assignment = assignment | ||
.withPrefix(currentArgs == null || currentArgs.isEmpty() ? Space.EMPTY : Space.SINGLE_SPACE) | ||
.withAssignment(assignment.getAssignment().withType(fetchTypeType)) | ||
.withType(fetchTypeType); | ||
return ann.withArguments(ListUtils.concat(currentArgs, assignment)); | ||
} | ||
|
||
private <T extends J> T removeLazyCollectionAnnotation(T tree, ExecutionContext ctx) { | ||
Optional<J.Annotation> lazyAnnotation = FindAnnotations.find(tree, "org.hibernate.annotations.LazyCollection") | ||
.stream().findFirst(); | ||
if (!lazyAnnotation.isPresent()) { | ||
return tree; | ||
} | ||
|
||
// Capture the FetchType from the LazyCollectionOption | ||
List<Expression> arguments = lazyAnnotation.get().getArguments(); | ||
if (arguments == null || arguments.isEmpty()) { | ||
// default is LazyCollectionOption.TRUE | ||
getCursor().putMessage("fetchType", "FetchType.LAZY"); | ||
} else { | ||
switch (arguments.get(0).toString()) { | ||
case "LazyCollectionOption.FALSE": | ||
getCursor().putMessage("fetchType", "FetchType.EAGER"); | ||
break; | ||
case "LazyCollectionOption.TRUE": | ||
getCursor().putMessage("fetchType", "FetchType.LAZY"); | ||
break; | ||
default: | ||
// EXTRA can't be mapped to a FetchType; requires refactoring | ||
return tree; | ||
} | ||
} | ||
//noinspection unchecked | ||
return (T) new RemoveAnnotationVisitor(new AnnotationMatcher("@org.hibernate.annotations.LazyCollection")) | ||
.visit(tree, ctx, getCursor()); | ||
} | ||
}); | ||
} | ||
} |
Oops, something went wrong.