Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at file inclusions #369

Closed
wants to merge 5 commits into from
Closed

First stab at file inclusions #369

wants to merge 5 commits into from

Conversation

Laurens-W
Copy link

What's changed?

Added inclusion as a counter to exclusions

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@sambsnyd

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W added the enhancement New feature or request label Feb 10, 2025
@Laurens-W Laurens-W requested a review from sambsnyd February 10, 2025 17:33
@Laurens-W Laurens-W self-assigned this Feb 10, 2025
@Laurens-W Laurens-W marked this pull request as ready for review February 17, 2025 16:05
@sambsnyd
Copy link
Member

So this is good but does it have exactly the same semantics as the FileInclusion we use in the CLI? If not we're inviting bugs and drift. Can we move that class into rewrite-polyglot and reuse it here, in the maven plugin, and in the Gradle plugin?

@Laurens-W Laurens-W closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants