diff --git a/openreview/arr/helpers.py b/openreview/arr/helpers.py index 5e1a189ae..1ceabcfc3 100644 --- a/openreview/arr/helpers.py +++ b/openreview/arr/helpers.py @@ -1172,16 +1172,6 @@ class Participants(Enum): 'Blind_Submission_License_Agreement': 'Submission_Revision_Stage' } FIELD_READERS = { - 'Official_Review': { - 'content_name': 'additional_review_form_options', - 'fields': { - 'reviewer_certification': [ - Participants.SENIOR_AREA_CHAIRS_ASSIGNED, - Participants.AREA_CHAIRS_ASSIGNED, - Participants.SIGNATURE - ] - } - } } UPDATE_WAIT_TIME = 5 diff --git a/openreview/stages/arr_content.py b/openreview/stages/arr_content.py index e04d52b48..473b63963 100644 --- a/openreview/stages/arr_content.py +++ b/openreview/stages/arr_content.py @@ -1499,15 +1499,14 @@ "order": 22 }, "reviewer_certification": { + "order": 23, "value": { "param": { - "minLength": 1, - "optional": False, - "type": "string" + "type": "string", + "enum": [{ "value": "Yes", "description": "I certify that the review I entered accurately reflects my assessment of the work. If you used any type of automated tool to help you craft your review, I hereby certify that its use was restricted to improving grammar and style, and the substance of the review is either my own work or the work of an acknowledged secondary reviewer."}], + "input": "checkbox" } - }, - "description": "By filling in your name here you certify that the review you entered accurately reflects your assessment of the work. If you used any type of automated tool to help you craft your review, you hereby certify that its use was restricted to improving grammar and style, and the substance of the review is either your own work or the work of an acknowledged secondary reviewer.", - "order": 23 + } } } diff --git a/tests/test_arr_venue_v2.py b/tests/test_arr_venue_v2.py index b0a117664..0b1bcd6c4 100644 --- a/tests/test_arr_venue_v2.py +++ b/tests/test_arr_venue_v2.py @@ -2515,7 +2515,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h "Knowledge_of_paper": {"value": "After the review process started"}, "Knowledge_of_paper_source": {"value": ["A research talk"]}, "impact_of_knowledge_of_paper": {"value": "A lot"}, - "reviewer_certification": {"value": "A Name"} + "reviewer_certification": {"value": "Yes"} } ) ) @@ -2541,7 +2541,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h "Knowledge_of_paper": {"value": "After the review process started"}, "Knowledge_of_paper_source": {"value": ["A research talk"]}, "impact_of_knowledge_of_paper": {"value": "A lot"}, - "reviewer_certification": {"value": "A Name"} + "reviewer_certification": {"value": "Yes"} } ) ) @@ -2574,7 +2574,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h "Knowledge_of_paper": {"value": "After the review process started"}, "Knowledge_of_paper_source": {"value": ["A research talk"]}, "impact_of_knowledge_of_paper": {"value": "A lot"}, - "reviewer_certification": {"value": "A Name"} + "reviewer_certification": {"value": "Yes"} } ) ) @@ -2603,7 +2603,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h "Knowledge_of_paper": {"value": "After the review process started"}, "Knowledge_of_paper_source": {"value": ["A research talk"]}, "impact_of_knowledge_of_paper": {"value": "A lot"}, - "reviewer_certification": {"value": "A Name"} + "reviewer_certification": {"value": "Yes"} } ) ) @@ -3293,7 +3293,7 @@ def generate_official_review_content(tested_field=None): "Knowledge_of_paper": {"value": "After the review process started"}, "Knowledge_of_paper_source": {"value": ["A research talk"]}, "impact_of_knowledge_of_paper": {"value": "A lot"}, - "reviewer_certification": {"value": "A Name"} + "reviewer_certification": {"value": "Yes"} } ret_content['ethical_concerns'] = {'value': 'There are no concerns with this submission'} @@ -3332,12 +3332,7 @@ def generate_official_review_content(tested_field=None): time.sleep(2) ## Wait for flag process functions review = pc_client_v2.get_note(id=rev_edit['note']['id']) - assert set(review.content['reviewer_certification']['readers']) == { - 'aclweb.org/ACL/ARR/2023/August/Program_Chairs', - f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs", - f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs", - review.signatures[0] - } + assert 'readers' not in review.content['reviewer_certification'] return rev_edit, pc_client_v2.get_note(test_submission.id) @@ -3450,12 +3445,7 @@ def now(): review = openreview_client.get_note(reviewer_edit['note']['id']) assert 'aclweb.org/ACL/ARR/2023/August/Submission3/Authors' in review.readers - assert set(review.content['reviewer_certification']['readers']) == { - 'aclweb.org/ACL/ARR/2023/August/Program_Chairs', - f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs", - f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs", - review.signatures[0] - } + assert 'readers' not in review.content['reviewer_certification'] # Edit with ethics flag to double check that authors are present _, test_submission = post_official_review(user_client, review_inv, user, tested_field='needs_ethics_review', existing_note=reviewer_edit['note'])