Skip to content

Commit

Permalink
Fix/arr reviewer certification (#2205)
Browse files Browse the repository at this point in the history 
* increase package version

* add signatures to be readers of the hidden field

* pass only values

* use a checkbox instead of a texbox for reviewer certification

---------

Co-authored-by: Celeste Martinez <celeste@openreview.net>
Co-authored-by: celestemartinez <32438984+celestemartinez@users.noreply.github.com>
Co-authored-by: Harold Rubio <43583679+haroldrubio@users.noreply.github.com>
  • Loading branch information
@melisabok @celestemartinez @haroldrubio
4 people authored Jun 21, 2024
1 parent 799d93b commit 2396488
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 33 deletions.
10 changes: 0 additions & 10 deletions openreview/arr/helpers.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1172,16 +1172,6 @@ class Participants(Enum):
'Blind_Submission_License_Agreement': 'Submission_Revision_Stage'
}
FIELD_READERS = {
'Official_Review': {
'content_name': 'additional_review_form_options',
'fields': {
'reviewer_certification': [
Participants.SENIOR_AREA_CHAIRS_ASSIGNED,
Participants.AREA_CHAIRS_ASSIGNED,
Participants.SIGNATURE
]
}
}
}
UPDATE_WAIT_TIME = 5

Expand Down
11 changes: 5 additions & 6 deletions openreview/stages/arr_content.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1499,15 +1499,14 @@
"order": 22
},
"reviewer_certification": {
"order": 23,
"value": {
"param": {
"minLength": 1,
"optional": False,
"type": "string"
"type": "string",
"enum": [{ "value": "Yes", "description": "I certify that the review I entered accurately reflects my assessment of the work. If you used any type of automated tool to help you craft your review, I hereby certify that its use was restricted to improving grammar and style, and the substance of the review is either my own work or the work of an acknowledged secondary reviewer."}],
"input": "checkbox"
}
},
"description": "By filling in your name here you certify that the review you entered accurately reflects your assessment of the work. If you used any type of automated tool to help you craft your review, you hereby certify that its use was restricted to improving grammar and style, and the substance of the review is either your own work or the work of an acknowledged secondary reviewer.",
"order": 23
}
}
}

Expand Down
24 changes: 7 additions & 17 deletions tests/test_arr_venue_v2.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2515,7 +2515,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "A Name"}
"reviewer_certification": {"value": "Yes"}
}
)
)
Expand All @@ -2541,7 +2541,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "A Name"}
"reviewer_certification": {"value": "Yes"}
}
)
)
Expand Down Expand Up @@ -2574,7 +2574,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "A Name"}
"reviewer_certification": {"value": "Yes"}
}
)
)
Expand Down Expand Up @@ -2603,7 +2603,7 @@ def test_resubmission_and_track_matching_data(self, client, openreview_client, h
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "A Name"}
"reviewer_certification": {"value": "Yes"}
}
)
)
Expand Down Expand Up @@ -3293,7 +3293,7 @@ def generate_official_review_content(tested_field=None):
"Knowledge_of_paper": {"value": "After the review process started"},
"Knowledge_of_paper_source": {"value": ["A research talk"]},
"impact_of_knowledge_of_paper": {"value": "A lot"},
"reviewer_certification": {"value": "A Name"}
"reviewer_certification": {"value": "Yes"}
}
ret_content['ethical_concerns'] = {'value': 'There are no concerns with this submission'}

Expand Down Expand Up @@ -3332,12 +3332,7 @@ def generate_official_review_content(tested_field=None):
time.sleep(2) ## Wait for flag process functions

review = pc_client_v2.get_note(id=rev_edit['note']['id'])
assert set(review.content['reviewer_certification']['readers']) == {
'aclweb.org/ACL/ARR/2023/August/Program_Chairs',
f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs",
f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs",
review.signatures[0]
}
assert 'readers' not in review.content['reviewer_certification']

return rev_edit, pc_client_v2.get_note(test_submission.id)

Expand Down Expand Up @@ -3450,12 +3445,7 @@ def now():

review = openreview_client.get_note(reviewer_edit['note']['id'])
assert 'aclweb.org/ACL/ARR/2023/August/Submission3/Authors' in review.readers
assert set(review.content['reviewer_certification']['readers']) == {
'aclweb.org/ACL/ARR/2023/August/Program_Chairs',
f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Senior_Area_Chairs",
f"aclweb.org/ACL/ARR/2023/August/Submission{test_submission.number}/Area_Chairs",
review.signatures[0]
}
assert 'readers' not in review.content['reviewer_certification']

# Edit with ethics flag to double check that authors are present
_, test_submission = post_official_review(user_client, review_inv, user, tested_field='needs_ethics_review', existing_note=reviewer_edit['note'])
Expand Down

0 comments on commit 2396488

Please sign in to comment.