DEV: v1.33.0-SNAPSHOT #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added second signature for PDF-2 style header (this can be improved); - added support for PDF-2 headers to `PdfHeader`; and - more work required on valid major/minor version combinations.
- moved to an all Alpine stack for build and the final image; - now two Dockerfiles: - `Dockerfile` builds a tag by cloning the GitHub repo; - `Dockerfile_dev` builds a copy of the local project; - added templated versions of both the above that are so that they are updated automatically as part of the Maven build; and - updated the main `pom.xml` with a `resource` plugin to copy the `Dockerfile` and `Dockerfile_dev` to the base directory.
- refactored `PDF-hul` PDF Header parsing, particularly the version parsing; - no more `null` return handling, specific exceptions are thrown instead; - these are caught and handled in the `PdfModule` class; - new `PdfVersion` class to handle version parsing and comparison; - PDF version detection now handled by pattern match, with better reporting of errors; - offsets added to `PdfException`s that were in the scope of refactoring; - added new `%PDF-2.` signature to the `PDF-hul` module; - new `edu.harvard.hul.ois.jhove.messages.JhoveMessages.getMessageInstance` convenience method to clone message with sub-message; - added two new test cases to `PDF-hul` regression tests for header version detection; - added necessary `sed` insertions and file copies to handle changed integration test results to `jhove-bbt/scripts/create-1.33-target.sh`; and - refactored "not found" reporting for modules and handlers in jhove-apps `edu.harvard.hul.ois.jhove.Jhove` class. Error messages changed to give more detailed information: - `PDF-HUL-137`: - `PDF-HUL-148`: No longer mentions specific minor versions but has a more detailed sub-message - `PDF-HUL-155`: Reports the header that was too short New Error Messages: - `PDF-HUL-160`: IOException reading PDF header - `PDF-HUL-161`: PDF major version number should be 1.x or 2.x - `PDF-HUL-162`: Malformed PDF version number
- moved field declarations.
- added Dockerfile_installer which uses the JHOVE installer for a faster and more reliable way of building containers.
- fixes for date handling in the document info dictionary: - factored out getting the String literal from `addDateProperty` to `getDateLiteral` method, to simplify the methods; - no longer throwing a `PdfInvalidException` from `addDateProperty` so that bad dates don't halt docinfo processing, i.e. `ModDate` is still validated if `CreationDate` is invalid; - fixes to `jhove-bbt/scripts/create-1.33-target.sh' to adjust output affected by the above; and - bumped PDF module -> 1.12.7 and date.
- trim the key and value to prevent invalid XML; and - fix the test data.
FEAT: Slimline and templated Dockerfile
FEAT: PDF 2.0 header detection
FIX: Document info date parsing
FIX: Date error output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.