Skip to content

Commit

Permalink
Fixing security issue from exploit-db.com with edb-id 47772, Thanks t…
Browse files Browse the repository at this point in the history
…o John V for pointing it out and suggesting a fix. I chose to simply remove the option entirly as its use is very limited and I'd rather not even have exec option in the code
  • Loading branch information
mattpascoe committed Jan 29, 2020
1 parent 5f66419 commit 0ab7fd7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 22 deletions.
8 changes: 1 addition & 7 deletions www/plugins/ona_nmap_scans/report.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,7 @@ function rpt_output_html($form) {
if ($record['dbip'] == "NOT FOUND") continue;
// If it is only in the database then they should validate the ip or remove from database
if (($record['netip'] == $record['dbip']) or ($record['netdnsname'] != $record['dbdnsname'])) {
$action = <<<EOL
{$act_status_partial}
<a title="Ping"
class="act"
onClick="xajax_window_submit('tooltips', 'name=>tooltips', 'window_progressbar');xajax_window_submit('tooltips', 'ip=>{$record['dbip']}', 'ping');"
>Ping to verify</a> then delete as desired
EOL;
$action = "Ping to verify then delete as desired";
}
}

Expand Down
15 changes: 0 additions & 15 deletions www/winc/tooltips.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -2470,21 +2470,6 @@ function get_switchport_template_select($form) {
}


// Simple ping function that takes an IP in and pings it.. then shows the output in a module results window
function ws_ping($window_name, $form='') {

// If an array in a string was provided, build the array and store it in $form
$form = parse_options_string($form);

$output = shell_exec("ping -n -w 3 -c 3 {$form['ip']}");

$window['title'] = 'Ping Results';
$build_commit_html = 0;
$commit_function = '';
include(window_find_include('module_results'));
return(window_open("{$window_name}_results", $window));
}

/////////////////////////
// Setup empty window with a progress bar in it
//
Expand Down

0 comments on commit 0ab7fd7

Please sign in to comment.