Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-953: Support setting values of type "Location" #618

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mogoodrich
Copy link
Member

(standardize UUID method)

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@mogoodrich
Copy link
Member Author

Small follow-on commit to standardize on the less-restrictive isValidUuid method.

@mogoodrich mogoodrich requested review from mseaton and ibacher August 13, 2024 14:35
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 47.524% (-0.01%) from 47.536%
when pulling cb3fe8f on RESTWS-953-2
into 4f3e8ec on master.

@ibacher ibacher changed the title RESTWS-953:Support setting values of type "Location" RESTWS-953: Support setting values of type "Location" Aug 13, 2024
@mogoodrich
Copy link
Member Author

Thanks @mseaton @ibacher

@mogoodrich mogoodrich merged commit 8764f60 into master Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants