-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EA-184 - Move reporting module to an aware_of dependency #229
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cf7c477
Upgrade testdatamanager and ensures test data follows correct modelin…
mseaton 94482cf
Additional fix
mseaton 00bfd8d
EA-184 - Initial work to make hql available for awaiting admission
mseaton 417d1a6
Merge branch 'master' into EA-184-2
mseaton db67858
EA-184 - Demonstrate moving out of hql query builder and into an hql …
mseaton 03d6b78
EA-184 - Rename EmrVisitDAO to EmrApiDAO to reflect more generic intent
mseaton 4addd76
EA-184 - Remove dependencies on reporting objects from other code in …
mseaton 7786eeb
EA-184 - Remove residual references to the condition submodule and mo…
mseaton 5ab37a0
OpenmrsProfileAnnotation
mseaton 79fc27d
EA-184 - Fixes to conditional loading
mseaton cf56de4
EA-184 - Fixes to conditional loading
mseaton 0bccb57
EA-184 - Remove wildcard imports
mseaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
OpenmrsProfileAnnotation
- Loading branch information
commit 5ab37a0ce967ef9025330d30994fbb39a68dadf0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
api-reporting/src/test/java/org/openmrs/module/emrapi/BaseReportingTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package org.openmrs.module.emrapi; | ||
|
||
import org.openmrs.module.Module; | ||
import org.openmrs.module.ModuleFactory; | ||
import org.openmrs.test.BaseModuleContextSensitiveTest; | ||
|
||
import java.io.File; | ||
|
||
public abstract class BaseReportingTest extends BaseModuleContextSensitiveTest { | ||
|
||
public BaseReportingTest() { | ||
super(); | ||
{ | ||
Module mod = new Module("", "reporting", "", "", "", "1.25.0"); | ||
mod.setFile(new File("")); | ||
ModuleFactory.getStartedModulesMap().put(mod.getModuleId(), mod); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for retrieving visits awaiting admission was moved into the AdtService so that it can be used without relying on the reporting module. Then, the reporting module evaluator below was updated to call the implementation in the AdtService. None of the unit tests were changed, and all continue to pass.