Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate update AdvancedDaemonSet #1505

Merged
merged 2 commits into from
Mar 8, 2024

fix ut

603a441
Select commit
Loading
Failed to load commit list.
Merged

fix: validate update AdvancedDaemonSet #1505

fix ut
603a441
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 8, 2024 in 0s

47.81% (-0.75%) compared to 5421ee7

View this Pull Request on Codecov

47.81% (-0.75%) compared to 5421ee7

Details

Codecov Report

Attention: Patch coverage is 34.78261% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 47.81%. Comparing base (5421ee7) to head (603a441).
Report is 6 commits behind head on master.

Files Patch % Lines
...nset/validating/daemonset_create_update_handler.go 33.33% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1505      +/-   ##
==========================================
- Coverage   48.55%   47.81%   -0.75%     
==========================================
  Files         157      161       +4     
  Lines       22480    23395     +915     
==========================================
+ Hits        10916    11187     +271     
- Misses      10360    10995     +635     
- Partials     1204     1213       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.