1583 Frontend tour #2112
1583 Frontend tour #2112
Conversation
|
any plans adding translations? |
| line-height: 1.5; | ||
| color: #333; | ||
| min-width: 400px; | ||
| min-width: 200px; |
There was a problem hiding this comment.
which of these min-width should be used?
| import "./TourWrapper.scss"; | ||
|
|
||
| function CustomTooltip(props) { | ||
| const { backProps, closeProps, continuous, index, skipProps, primaryProps, step, tooltipProps } = props; |
There was a problem hiding this comment.
this could go directly into function definition so we know exactly what inputs to expect and no other props could sneak in
| ) : step.spotlightClicks ? ( | ||
| <> | ||
| <AdsClickIcon sx={{ fontSize: 80 }} /> | ||
| <p>Click & Try</p> |
There was a problem hiding this comment.
should come from translation files
| aria-labelledby="nested-list-subheader" | ||
| subheader={ | ||
| <ListSubheader component="div" id="nested-list-subheader"> | ||
| <strong>Jump to specific chapter</strong> |
There was a problem hiding this comment.
should be in translation files
| const initialState = ({ firstProjectId, firstSubprojectId }) => { | ||
| const beforeStart = [ | ||
| { | ||
| navigateTo: "/projects" |
There was a problem hiding this comment.
/projects could be constant as it appears several times below
| const steps = [ | ||
| { | ||
| target: "body", | ||
| content: "Welcome to TruBudget application tour.", |
There was a problem hiding this comment.
all the content texts should come from translations
| useEffect(() => { | ||
| if (tourActive && !ref.current) { | ||
| goToNextStepIf(); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
timeout should be cleared in useEffect return
| useEffect(() => { | ||
| if (tourActive && !ref.current) { | ||
| goToNextStepIf(); | ||
| setTimeout(() => { |
There was a problem hiding this comment.
clear timeout in return
Generated by E2E-Test |
Checklist
Description
How to test
Closes #1583