Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api:Update validation of env vars #2024

Merged
merged 2 commits into from
Oct 23, 2024
Merged

api:Update validation of env vars #2024

merged 2 commits into from
Oct 23, 2024

Conversation

galethil
Copy link
Collaborator

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. Start app with empty "SILENCE_LOGGING_ON_FREQUENT_ROUTES" variable

Copy link

github-actions bot commented Oct 16, 2024

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against 78a36a8

@openkfwCI
Copy link

openkfwCI commented Oct 16, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60648 on remote server failedTue, 22 Oct 2024 11:17:18 +0000

Generated by E2E-Test

@SamuelPull SamuelPull self-requested a review October 21, 2024 08:03
@SamuelPull
Copy link
Collaborator

Getting Error: Config validation error: "API_DB_NAME" is not allowed to be empty even when REFRESH_TOKEN_STORAGE=memory

@@ -99,6 +99,7 @@ services:
API_DB_PORT: ${API_DB_PORT}
API_DB_SSL: ${API_DB_SSL}
API_DB_SCHEMA: ${API_DB_SCHEMA}
API_DB_NAME: ${API_DB_NAME}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting Error: Config validation error: "API_DB_NAME" is not allowed to be empty even when REFRESH_TOKEN_STORAGE=memory

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelPull I fixed the issue with API_DB_NAME

@SamuelPull SamuelPull merged commit 6f2e50d into main Oct 23, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 2-17-minor-fixes branch October 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants