Implement a new client authentication method negotiation logic and introduce mTLS support in the client stack #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troduce mTLS support in the client stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2186.
This PR completely revamps how client authentication is implemented in the OpenIddict client by adopting the same negotiation logic that allows controlling what
grant_type/response_type/response_mode/code_challenge_methodis used for authorization or token requests.It also implements complete
tls_client_authandself_signed_tls_client_authsupport in the OpenIddict client for all endpoints (device authorization, token, introspection and revocation). It also implements mTLS support for userinfo requests, since it is required to support servers that issue certificate-bound access tokens.Note: for consistency, mTLS was also added in the validation stack for introspection requests.