Shorten isInverted checks

Signed-off-by: Michael Krug <michi.krug@gmail.com>
openhab · Mar 27, 2022 · 53c4d16 · 53c4d16
1 parent 7ef0a09
commit 53c4d16
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 4 deletions.
diff --git a/functions/commands/charge.js b/functions/commands/charge.js
@@ -24,7 +24,7 @@ class Charge extends DefaultCommand {
 
   static convertParamsToValue(params, _, device) {
     let charge = params.charge;
-    if (this.isInverted(device) === true) {
+    if (this.isInverted(device)) {
       charge = !charge;
     }
     return charge ? 'ON' : 'OFF';

diff --git a/functions/commands/mute.js b/functions/commands/mute.js
@@ -42,7 +42,7 @@ class Mute extends DefaultCommand {
     if (itemType !== 'Switch') {
       return mute ? '0' : undefined;
     }
-    if (this.isInverted(device) === true) {
+    if (this.isInverted(device)) {
       mute = !mute;
     }
     return mute ? 'ON' : 'OFF';

diff --git a/functions/commands/onoff.js b/functions/commands/onoff.js
@@ -39,7 +39,7 @@ class OnOff extends DefaultCommand {
 
   static convertParamsToValue(params, _, device) {
     let on = params.on;
-    if (this.isInverted(device) === true) {
+    if (this.isInverted(device)) {
       on = !on;
     }
     return on ? 'ON' : 'OFF';

diff --git a/functions/commands/openclose.js b/functions/commands/openclose.js
@@ -15,7 +15,7 @@ class OpenClose extends DefaultCommand {
       throw { statusCode: 400 };
     }
     let openPercent = params.openPercent;
-    if (this.isInverted(device) === true) {
+    if (this.isInverted(device)) {
       openPercent = 100 - openPercent;
     }
     if (itemType === 'Rollershutter') {

diff --git a/tests/commands/default.test.js b/tests/commands/default.test.js
@@ -71,6 +71,13 @@ describe('Default Command', () => {
     expect(Command.getItemName({ name: 'Item' }, {})).toBe('Item');
   });
 
+  test('isInverted', () => {
+    expect(Command.isInverted({})).toBe(false);
+    expect(Command.isInverted({ id: 'Item', customData: {} })).toBe(false);
+    expect(Command.isInverted({ id: 'Item', customData: { inverted: false } })).toBe(false);
+    expect(Command.isInverted({ id: 'Item', customData: { inverted: true } })).toBe(true);
+  });
+
   test('requiresItem', () => {
     expect(Command.requiresItem({})).toBe(false);
   });