Generate valid tags in thing-description-1.0.0.xsd

[jimtng]

Populates the list of valid Point and Property tags in thing-description-1.0.0.xsd

Depends on/Based on: #4622, #4615, #4617

[andrewfg]

Did you take into account also #4617 ?

[jimtng]

Did you take into account also #4617 ?

Nope, missed that one. Will add it shortly. This PR will wait until all those ones are merged first.

[jimtng]

@andrewfg in #4615 you have:

<!-- Allowed Property Tag Values -->

But in #4617 you have:

<!-- Allowed Semantic Equipment Tag Values -->

Do you prefer the version with or without the word Semantic?

[andrewfg]

I think it is clearer with the word semantic.

[jimtng]

Updated to include #4617, and made all the comments say Semantic

[andrewfg]

Brilliant. LGTM.

[andrewfg]

@jimtng just wondering if you need to add a spotless exclusion somewhere to prevent it falling over later on the generated java and xsd files?

[jimtng]

No, the result should be spotless-approved

[andrewfg]

@jimtng it works perfectly here

[andrewfg]

@jimtng since this PR is now dynamically generating the updated schema xsd file I wonder if I shall remove it from my own two PRs? You say you want to postpone your PR until mine is done. And perhaps I must postpone mine until yours is done? We need to ensure we avoid cross dependent merge conflicts.

EDIT: I think in my PRs I need to insert the begin/end markers in the XSD so your PR can later find and replace the lines between. Or??

EDIT2: I just noticed that the word "semantic" is missing from the end marker

			<!-- Begin Allowed Semantic Point Tag Values -->
			<!-- DO NOT EDIT THIS LIST - Generated by generateTagClasses.groovy -->
...
			<!-- End Allowed Point Tag Values -->

EDIT3: obviously this PR will fail its CI Build until after my PRs are merged; so that clarifies the merge sequence..

[andrewfg]

See

• e204508
• fec5432

[jimtng]

since this PR is now dynamically generating the updated schema xsd file I wonder if I shall remove it from my own two PRs? You say you want to postpone your PR until mine is done. And perhaps I must postpone mine until yours is done? We need to ensure we avoid cross dependent merge conflicts.

I think by now you've realised that your PR needs to go in first, with a static list of tags. It would only then make sense for this PR to be merged to generate that list.

EDIT2: I just noticed that the word "semantic" is missing from the end marker

Good catch, thanks! I've added them now.

EDIT3: obviously this PR will fail its CI Build until after my PRs are merged; so that clarifies the merge sequence..

Yup!

[andrewfg]

your PR needs to go in first, with a static list of tags

Agreed.