Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blake2engine: Use .data() to get pointer to data and not .begin() #742

Closed
wants to merge 1 commit into from

Conversation

autoantwort
Copy link
Contributor

.begin() could return an iterator object depending on the build context

@yspolyakov
Copy link
Contributor

@autoantwort We typically create issues and discuss them before creating PRs. I see many small PRs from you (which is overwhelming), and their motivation is not clear. My suggestion is to create one PR with all small fixes/cleanups, and we can later discuss these together. For the time being, I will close the PRs that have been open.

@yspolyakov yspolyakov closed this Apr 19, 2024
@autoantwort
Copy link
Contributor Author

So you prefer one big PR with many unrelated changes instead of one PR per concern?
Should I create one Issue for every PR / Concern or one Big one?

@yspolyakov
Copy link
Contributor

I suggest discussing the problem first. We want to understand the motivation before reviewing the PRs. Many PRs appeared very small. You can create an issue for each separate problem. A PR can afterwards be created for multiple issues.

@autoantwort
Copy link
Contributor Author

I have created #770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants