Validate multDepth as a cryptocontext parameter #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caesaretos
reviewed
Dec 6, 2023
There was a problem hiding this comment.
OpenFHE is unlikely able to support more than ~100-200 multiplicative depths, and we better not claim that OpenFHE supports it (as the message implies). The upper limit 1000 has no scientific basis and better not be printed out to the user.
Something along the following message would be more meaningful.
"The multiplicative depth of entered_val may not be computationally feasible. Please try a smaller depth, such as 30, to improve performance"
dsuponitskiy
deleted the
576-segfault-when-multiplicativedepth-is-negative
branch
dsuponitskiy
restored the
576-segfault-when-multiplicativedepth-is-negative
branch
yspolyakov
deleted the
576-segfault-when-multiplicativedepth-is-negative
branch
gong-cr
pushed a commit
to gong-cr/openfhe-development
that referenced
this pull request
Mar 6, 2024
* Validate multDepth as a cryptocontext parameter * Rephrased the error message for multiplicative depth --------- Co-authored-by: Dmitriy Suponitskiy <dsuponitskiy@dualitytech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.