Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some suggestions #800

Open
HovsepPapoyan opened this issue Jun 11, 2024 · 0 comments
Open

Some suggestions #800

HovsepPapoyan opened this issue Jun 11, 2024 · 0 comments
Assignees
Labels
cleanup Code cleanup

Comments

@HovsepPapoyan
Copy link

  1. In the following funtions, instead of "std::string" it would be nice to use "const std::string&":

template
static bool SerializeEvalAutomorphismKey(std::ostream& ser, const ST& sertype, std::string id = "");
template
static bool SerializeEvalMultKey(std::ostream& ser, const ST& sertype, std::string id = "");
template
static bool SerializeEvalSumKey(std::ostream& ser, const ST& sertype, std::string id = "");

  1. In the following function, instead of "std::vector<uint32_t>" it would be nice to use "const std::vector<uint32_t>&":

void EvalBootstrapSetup(std::vector<uint32_t> levelBudget = {5, 4}, std::vector<uint32_t> dim1 = {0, 0},
uint32_t slots = 0, uint32_t correctionFactor = 0, bool precompute = true);

  1. For the sake of completness it might be worth to provide this variant also:

Ciphertext EvalInnerProduct(ConstPlaintext plaintext, ConstCiphertext ciphertext,
usint batchSize) const;

  1. It would be a good idea to provide noexcept guarantees whenever possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup
Projects
None yet
Development

No branches or pull requests

3 participants