feat(java-sdk)!: support server-side batch check endpoint #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
requested changes
Feb 5, 2025
There was a problem hiding this comment.
@piotrooo this is awesome!!! Thanks so much for your contribution 🙇
Just a couple fairly minor requests and a question about the new exception type.
config/clients/java/template/errors-FgaValidationError.java.mustache
Outdated
Show resolved
Hide resolved
config/clients/java/template/config-ClientBatchCheckClientRequestOptions.java.mustache
Outdated
Show resolved
Hide resolved
config/clients/java/template/config-ClientBatchCheckRequestOptions.java.mustache
Outdated
Show resolved
Hide resolved
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caution
Breaking Change! This change renames the existing
batchCheckmethod (which calls the /check API in parallel) toclientBatchCheck.If you would like to continue to use the client-side batch check, replace your calls to
batchCheckwithclientBatchCheck, and reference the results using the result property (formerly was responses).Implemented a server-side batch check API, as @jimmyjames mentioned here.
References
Review Checklist
main